-
-
Notifications
You must be signed in to change notification settings - Fork 999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add maximize button for Modal #2573
Add maximize button for Modal #2573
Conversation
Codecov Report
@@ Coverage Diff @@
## feature #2573 +/- ##
===========================================
+ Coverage 27.87% 29.48% +1.61%
===========================================
Files 503 541 +38
Lines 33922 26237 -7685
Branches 0 260 +260
===========================================
- Hits 9455 7736 -1719
+ Misses 24467 18461 -6006
- Partials 0 40 +40
Continue to review full report at Codecov.
|
4599e12
to
b52fe88
Compare
b52fe88
to
8ab1d78
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* add maximizable button for Modal * fix: patch.less * export MaximizeBtnIcon and RestoreBtnIcon paramter * refactor: fixed foote
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
Allow Modal to maximize within the browser.
Note:
Draggable
is true, the position will be reset when the size is restored允许Modal在浏览器内最大化。
注意:
Draggable
为true,恢复大小的时候将会重置位置modal-max.mp4
📝 Changelog
☑️ Self Check before Merge