Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add maximize button for Modal #2573

Merged

Conversation

zxyao145
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

Allow Modal to maximize within the browser.
Note:

  1. If Draggable is true, the position will be reset when the size is restored
  2. It is turned off when the Modal is maximized, and it will remain maximized when it is displayed again

允许Modal在浏览器内最大化。
注意:

  1. 如果Draggable为true,恢复大小的时候将会重置位置
  2. 当Modal最大化的时候被关闭,再次显示的时候会保持最大化的样子
modal-max.mp4

📝 Changelog

Language Changelog
🇺🇸 English Allow Modal to maximize within the browser.
🇨🇳 Chinese 允许Modal在浏览器内最大化。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Jul 17, 2022

@zxyao145 zxyao145 requested a review from ElderJames July 17, 2022 12:34
@codecov
Copy link

codecov bot commented Jul 17, 2022

Codecov Report

Merging #2573 (c5efd01) into feature (c00dd6f) will increase coverage by 1.61%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           feature    #2573      +/-   ##
===========================================
+ Coverage    27.87%   29.48%   +1.61%     
===========================================
  Files          503      541      +38     
  Lines        33922    26237    -7685     
  Branches         0      260     +260     
===========================================
- Hits          9455     7736    -1719     
+ Misses       24467    18461    -6006     
- Partials         0       40      +40     
Impacted Files Coverage Δ
components/modal/config/DialogOptions.cs 0.00% <0.00%> (ø)
components/modal/config/DialogOptionsBase.cs 0.00% <0.00%> (ø)
components/modal/config/ModalOptions.cs 0.00% <0.00%> (ø)
components/modal/core/Dialog.razor 0.00% <0.00%> (ø)
components/modal/core/Dialog.razor.cs 0.00% <0.00%> (ø)
components/modal/modalDialog/Modal.razor.cs 0.00% <0.00%> (ø)
components/modal/modalDialog/ModalContainer.razor 0.00% <ø> (ø)
components/core/Helpers/MemberPath/PathNode.cs 46.15% <0.00%> (-8.85%) ⬇️
components/core/Reflection/TypeDefined.cs 77.77% <0.00%> (-7.94%) ⬇️
components/input/InputGroup.razor.cs 87.50% <0.00%> (-6.95%) ⬇️
... and 449 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c00dd6f...c5efd01. Read the comment docs.

@zxyao145 zxyao145 changed the base branch from master to feature July 19, 2022 04:36
Copy link
Member

@ElderJames ElderJames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ElderJames ElderJames merged commit 4818d8b into ant-design-blazor:feature Jul 23, 2022
ElderJames pushed a commit that referenced this pull request Sep 6, 2022
* add maximizable button for Modal

* fix: patch.less

* export MaximizeBtnIcon and RestoreBtnIcon paramter

* refactor: fixed foote
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants