Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: statistic): make CountDown reset after the value was changed #2587

Merged
merged 3 commits into from
Aug 8, 2022
Merged

fix(module: statistic): make CountDown reset after the value was changed #2587

merged 3 commits into from
Aug 8, 2022

Conversation

WhyILoveSpringRoll
Copy link
Contributor

@WhyILoveSpringRoll WhyILoveSpringRoll commented Jul 29, 2022

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English CountDown can auto refresh when set value
🇨🇳 Chinese 添加CountDown的reset功能,设置绑定的value后countdown会自动刷新

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Jul 29, 2022

@codecov
Copy link

codecov bot commented Jul 29, 2022

Codecov Report

Merging #2587 (221a85f) into master (a0fbf6b) will increase coverage by 1.86%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #2587      +/-   ##
==========================================
+ Coverage   27.79%   29.66%   +1.86%     
==========================================
  Files         497      520      +23     
  Lines       33447    25695    -7752     
  Branches        0      250     +250     
==========================================
- Hits         9298     7622    -1676     
+ Misses      24149    18033    -6116     
- Partials        0       40      +40     
Impacted Files Coverage Δ
components/statistic/CountDown.razor.cs 0.00% <0.00%> (ø)
...mponents/statistic/StatisticComponentBase.razor.cs 0.00% <0.00%> (ø)
components/core/Helpers/MemberPath/PathNode.cs 46.15% <0.00%> (-8.85%) ⬇️
components/core/Reflection/TypeDefined.cs 77.77% <0.00%> (-7.94%) ⬇️
components/input/InputGroup.razor.cs 87.50% <0.00%> (-6.95%) ⬇️
components/timeline/Timeline.razor.cs 60.43% <0.00%> (-5.02%) ⬇️
...ponents/date-picker/types/DatePickerPlaceholder.cs 22.72% <0.00%> (-4.20%) ⬇️
...ponents/core/Component/Overlay/type/TriggerType.cs 81.25% <0.00%> (-2.97%) ⬇️
components/core/Helpers/DateHelper.cs 80.00% <0.00%> (-2.71%) ⬇️
...onents/date-picker/internal/DatePickerHeader.razor 43.90% <0.00%> (-2.48%) ⬇️
... and 425 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ElderJames ElderJames changed the title 添加CountDown的reset功能,设置绑定的value后countdown会自动刷新 fix(module: statistic): make CountDown reset after the value was changed Aug 6, 2022
@ElderJames ElderJames merged commit cbd9e53 into ant-design-blazor:master Aug 8, 2022
ElderJames added a commit that referenced this pull request Sep 6, 2022
…ged (#2587)

* 添加CountDown的reset功能,设置绑定的value后countdown会自动刷新

* 在CountDown Dispose时释放内部Timer

* update demo

Co-authored-by: James Yeung <shunjiey@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants