Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: image): an image which was setted after a fallback image can't display in preview #2599

Merged
merged 1 commit into from
Aug 9, 2022

Conversation

ElderJames
Copy link
Member

@ElderJames ElderJames commented Aug 8, 2022

…can't display in preview

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fixed #2595

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English an image which was setted after a fallback image can't display in preview
🇨🇳 Chinese 在回退图像后设置的图像无法在预览中显示

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@ElderJames ElderJames changed the title fix(module: image): an image which was setted after a fallback image … fix(module: image): an image which was setted after a fallback image can't display in preview Aug 8, 2022
@github-actions
Copy link

github-actions bot commented Aug 8, 2022

@ElderJames ElderJames changed the base branch from master to feature August 8, 2022 08:41
@ElderJames ElderJames force-pushed the fix/image/fix-image-set-preview branch from fd497d1 to ca935ca Compare August 8, 2022 08:42
@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #2599 (ca935ca) into feature (5d127bf) will increase coverage by 1.71%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           feature    #2599      +/-   ##
===========================================
+ Coverage    29.21%   30.92%   +1.71%     
===========================================
  Files          504      542      +38     
  Lines        34200    26347    -7853     
  Branches         0      260     +260     
===========================================
- Hits          9990     8148    -1842     
+ Misses       24210    18159    -6051     
- Partials         0       40      +40     
Impacted Files Coverage Δ
components/image/Image.razor.cs 0.00% <0.00%> (ø)
components/core/Helpers/MemberPath/PathNode.cs 46.15% <0.00%> (-8.85%) ⬇️
components/core/Reflection/TypeDefined.cs 77.77% <0.00%> (-7.94%) ⬇️
components/input/InputGroup.razor.cs 87.50% <0.00%> (-6.95%) ⬇️
components/core/Helpers/DateHelper.cs 85.33% <0.00%> (-4.90%) ⬇️
...ponents/date-picker/types/DatePickerPlaceholder.cs 22.72% <0.00%> (-4.20%) ⬇️
...onents/date-picker/internal/DatePickerHeader.razor 41.86% <0.00%> (-3.21%) ⬇️
...ponents/core/Component/Overlay/type/TriggerType.cs 81.25% <0.00%> (-2.97%) ⬇️
components/core/Base/AntComponentBase.cs 53.57% <0.00%> (-2.68%) ⬇️
components/menu/SubMenu.razor 63.93% <0.00%> (-2.30%) ⬇️
... and 444 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@ElderJames ElderJames merged commit c427ad3 into feature Aug 9, 2022
@ElderJames ElderJames deleted the fix/image/fix-image-set-preview branch August 9, 2022 00:24
ElderJames added a commit that referenced this pull request Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image compoment, when change src, the preview is still error image
1 participant