Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module: image): support controlled preview #2600

Merged
merged 1 commit into from
Aug 9, 2022

Conversation

ElderJames
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English support controlled preview
🇨🇳 Chinese 支持可控预览

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Aug 8, 2022

@ElderJames ElderJames changed the base branch from master to feature August 8, 2022 08:44
@ElderJames ElderJames force-pushed the feat/image-controlled-preview branch from 79b93a2 to cd74324 Compare August 8, 2022 08:45
@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #2600 (cd74324) into feature (5d127bf) will increase coverage by 1.70%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           feature    #2600      +/-   ##
===========================================
+ Coverage    29.21%   30.91%   +1.70%     
===========================================
  Files          504      542      +38     
  Lines        34200    26359    -7841     
  Branches         0      260     +260     
===========================================
- Hits          9990     8148    -1842     
+ Misses       24210    18171    -6039     
- Partials         0       40      +40     
Impacted Files Coverage Δ
components/image/Image.razor 0.00% <ø> (ø)
components/image/Image.razor.cs 0.00% <0.00%> (ø)
components/core/Helpers/MemberPath/PathNode.cs 46.15% <0.00%> (-8.85%) ⬇️
components/core/Reflection/TypeDefined.cs 77.77% <0.00%> (-7.94%) ⬇️
components/input/InputGroup.razor.cs 87.50% <0.00%> (-6.95%) ⬇️
components/core/Helpers/DateHelper.cs 85.33% <0.00%> (-4.90%) ⬇️
...ponents/date-picker/types/DatePickerPlaceholder.cs 22.72% <0.00%> (-4.20%) ⬇️
...onents/date-picker/internal/DatePickerHeader.razor 41.86% <0.00%> (-3.21%) ⬇️
...ponents/core/Component/Overlay/type/TriggerType.cs 81.25% <0.00%> (-2.97%) ⬇️
components/core/Base/AntComponentBase.cs 53.57% <0.00%> (-2.68%) ⬇️
... and 445 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ElderJames ElderJames merged commit 367306a into feature Aug 9, 2022
@ElderJames ElderJames deleted the feat/image-controlled-preview branch August 9, 2022 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant