Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(module: select): change events from Action to EventCallback #2601

Merged
merged 2 commits into from
Aug 9, 2022
Merged

fix(module: select): change events from Action to EventCallback #2601

merged 2 commits into from
Aug 9, 2022

Conversation

ElderJames
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fixed #2572

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Aug 8, 2022 •
edited

@ElderJames ElderJames linked an issue Aug 8, 2022 that may be closed by this pull request
SimpleSelect get a error when binding a async method to OnSelectedItemChanged #2572
Closed
@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #2601 (8721ba2) into feature (5d127bf) will increase coverage by 1.67%.
The diff coverage is 73.33%.

@@             Coverage Diff             @@
##           feature    #2601      +/-   ##
===========================================
+ Coverage    29.21%   30.88%   +1.67%     
===========================================
  Files          504      543      +39     
  Lines        34200    26390    -7810     
  Branches         0      260     +260     
===========================================
- Hits          9990     8150    -1840     
+ Misses       24210    18200    -6010     
- Partials         0       40      +40
Impacted Files Coverage Δ
components/dropdown/DropdownButton.cs 64.70% <0.00%> (+1.59%) ⬆️
components/select/SelectBase.cs 71.27% <75.00%> (+5.24%) ⬆️
components/select/Select.razor.cs 53.11% <100.00%> (+2.19%) ⬆️
components/core/Helpers/MemberPath/PathNode.cs 46.15% <0.00%> (-8.85%) ⬇️
components/core/Reflection/TypeDefined.cs 77.77% <0.00%> (-7.94%) ⬇️
components/input/InputGroup.razor.cs 87.50% <0.00%> (-6.95%) ⬇️
components/core/Helpers/DateHelper.cs 85.33% <0.00%> (-4.90%) ⬇️
...ponents/date-picker/types/DatePickerPlaceholder.cs 22.72% <0.00%> (-4.20%) ⬇️
...onents/date-picker/internal/DatePickerHeader.razor 41.86% <0.00%> (-3.21%) ⬇️
...ponents/core/Component/Overlay/type/TriggerType.cs 81.25% <0.00%> (-2.97%) ⬇️
... and 447 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ElderJames ElderJames merged commit 01a618a into feature Aug 9, 2022
@ElderJames ElderJames deleted the fix/select-event-callback branch August 9, 2022 06:21
ElderJames added a commit that referenced this pull request Sep 6, 2022
@ElderJames
fix(module: select): change events from Action to EventCallback (#…
b604d5f 
…2601)

* fix(module: select): change events from `Action` to `EventCallback`

* fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SimpleSelect get a error when binding a async method to OnSelectedItemChanged
1 participant
@ElderJames