Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: select):When ignoreitemchanges is false, deleting multiple selections will cause an exception #2620

Merged
merged 3 commits into from
Aug 20, 2022

Conversation

WhyILoveSpringRoll
Copy link
Contributor

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English fix(module: select):When ignoreitemchanges is false, deleting multiple selections will cause an exception #2617
🇨🇳 Chinese 修复当ignoreitemchanges=false时,删除select的已选择标签会报错的问题 #2617

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Aug 17, 2022

@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #2620 (bb78d6a) into master (a0fbf6b) will increase coverage by 1.85%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2620      +/-   ##
==========================================
+ Coverage   27.79%   29.65%   +1.85%     
==========================================
  Files         497      520      +23     
  Lines       33447    25695    -7752     
  Branches        0      250     +250     
==========================================
- Hits         9298     7620    -1678     
+ Misses      24149    18035    -6114     
- Partials        0       40      +40     
Impacted Files Coverage Δ
components/select/Select.razor.cs 53.12% <ø> (+2.21%) ⬆️
components/core/Helpers/MemberPath/PathNode.cs 46.15% <0.00%> (-8.85%) ⬇️
components/core/Reflection/TypeDefined.cs 77.77% <0.00%> (-7.94%) ⬇️
components/input/InputGroup.razor.cs 87.50% <0.00%> (-6.95%) ⬇️
components/timeline/Timeline.razor.cs 60.43% <0.00%> (-5.02%) ⬇️
...ponents/date-picker/types/DatePickerPlaceholder.cs 22.72% <0.00%> (-4.20%) ⬇️
...ponents/core/Component/Overlay/type/TriggerType.cs 81.25% <0.00%> (-2.97%) ⬇️
components/core/Helpers/DateHelper.cs 80.00% <0.00%> (-2.71%) ⬇️
...onents/date-picker/internal/DatePickerHeader.razor 43.90% <0.00%> (-2.48%) ⬇️
components/menu/SubMenu.razor 63.93% <0.00%> (-2.30%) ⬇️
... and 424 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ElderJames ElderJames merged commit 086829c into ant-design-blazor:master Aug 20, 2022
ElderJames pushed a commit that referenced this pull request Sep 6, 2022
…le selections will cause an exception (#2620)

* 修复TreeNode的Disable和Checked属性共存不生效的问题

* Revert "修复TreeNode的Disable和Checked属性共存不生效的问题"

This reverts commit 7f91959.

* fix(module: Select):When ignoreitemchanges is false, deleting multiple selections will cause an exception
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants