Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upload control and add webp ext and custom image extension #2626

Merged
merged 1 commit into from
Aug 19, 2022

Conversation

AigioL
Copy link
Contributor

@AigioL AigioL commented Aug 19, 2022

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Uploading control image recognition supports user-defined modification of image file extension, adding webp format, and repairing that the filename does not exist. A subscript out of range exception is generated
🇨🇳 Chinese 上传控件图片识别支持自定义修改图片文件扩展名,与添加 WebP 格式,修复 FileName 不存在 . 时产生下标越界异常

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Aug 19, 2022

@ElderJames
Copy link
Member

ElderJames commented Aug 19, 2022

Thanks for contribute this @AigioL . Please check if this PR have fixed the issue #2043

@codecov
Copy link

codecov bot commented Aug 19, 2022

Codecov Report

Merging #2626 (788a5ef) into master (02b0dd2) will increase coverage by 1.95%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #2626      +/-   ##
==========================================
+ Coverage   27.62%   29.58%   +1.95%     
==========================================
  Files         497      520      +23     
  Lines       33545    25700    -7845     
  Branches        0      250     +250     
==========================================
- Hits         9268     7603    -1665     
+ Misses      24277    18057    -6220     
- Partials        0       40      +40     
Impacted Files Coverage Δ
components/upload/UploadFileItem.cs 0.00% <0.00%> (ø)
components/core/Helpers/MemberPath/PathNode.cs 46.15% <0.00%> (-8.85%) ⬇️
components/core/Reflection/TypeDefined.cs 77.77% <0.00%> (-7.94%) ⬇️
components/input/InputGroup.razor.cs 87.50% <0.00%> (-6.95%) ⬇️
...ponents/date-picker/types/DatePickerPlaceholder.cs 22.72% <0.00%> (-4.20%) ⬇️
...ponents/core/Component/Overlay/type/TriggerType.cs 81.25% <0.00%> (-2.97%) ⬇️
components/core/Helpers/DateHelper.cs 80.00% <0.00%> (-2.71%) ⬇️
...onents/date-picker/internal/DatePickerHeader.razor 43.90% <0.00%> (-2.48%) ⬇️
components/menu/SubMenu.razor 63.93% <0.00%> (-2.30%) ⬇️
components/timeline/Timeline.razor.cs 60.43% <0.00%> (-2.17%) ⬇️
... and 424 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@AigioL
Copy link
Contributor Author

AigioL commented Aug 19, 2022

Thanks for contribute this @AigioL . Please check if this PR have fixed the issue #2043

Yes, this PR will be repaired #2043

Copy link
Member

@ElderJames ElderJames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants