-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MessageService to implement and register as an interface #2633
Update MessageService to implement and register as an interface #2633
Conversation
Thanks for contribute this @kooliokey . |
Codecov Report
@@ Coverage Diff @@
## master #2633 +/- ##
==========================================
+ Coverage 29.16% 30.82% +1.65%
==========================================
Files 505 543 +38
Lines 34359 26420 -7939
Branches 0 260 +260
==========================================
- Hits 10021 8144 -1877
+ Misses 24338 18236 -6102
- Partials 0 40 +40
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…w mocking for testing in external applications. Update documentation to use the new method of calling by injecting IMessageService.
c9f4279
to
d6d8228
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🤔 This is a ...
🔗 Related issue link
#2631
💡 Background and solution
Testing that an application triggers an AntDesign.Message is not currently possible because it is defined only as a concrete class. Refactoring it to be a class implementing an interface allows us to inject the interface into code and thus allows unit testing.
📝 Changelog
☑️ Self Check before Merge