Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(form): neither input nor validation message was highlighted when … #2639

Merged
merged 2 commits into from
Aug 25, 2022

Conversation

YongQuan-dotnet
Copy link
Collaborator

@YongQuan-dotnet YongQuan-dotnet commented Aug 25, 2022

…not valid.

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Aug 25, 2022

@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #2639 (3203a13) into master (550ad28) will increase coverage by 1.65%.
The diff coverage is 50.00%.

❗ Current head 3203a13 differs from pull request most recent head b1d084c. Consider uploading reports for the commit b1d084c to get more accurate results

@@            Coverage Diff             @@
##           master    #2639      +/-   ##
==========================================
+ Coverage   29.16%   30.82%   +1.65%     
==========================================
  Files         505      543      +38     
  Lines       34348    26424    -7924     
  Branches        0      260     +260     
==========================================
- Hits        10019     8145    -1874     
+ Misses      24329    18239    -6090     
- Partials        0       40      +40     
Impacted Files Coverage Δ
components/form/FormItem.razor 60.00% <0.00%> (+4.44%) ⬆️
components/input/InputPassword.razor.cs 0.00% <0.00%> (ø)
components/input/Input.cs 66.90% <80.00%> (+4.62%) ⬆️
components/form/FormItem.razor.cs 43.31% <100.00%> (+5.17%) ⬆️
components/core/Helpers/MemberPath/PathNode.cs 46.15% <0.00%> (-8.85%) ⬇️
components/core/Reflection/TypeDefined.cs 77.77% <0.00%> (-7.94%) ⬇️
components/input/InputGroup.razor.cs 87.50% <0.00%> (-6.95%) ⬇️
components/core/Helpers/DateHelper.cs 85.33% <0.00%> (-4.90%) ⬇️
...ponents/date-picker/types/DatePickerPlaceholder.cs 22.72% <0.00%> (-4.20%) ⬇️
...onents/date-picker/internal/DatePickerHeader.razor 41.86% <0.00%> (-3.21%) ⬇️
... and 447 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ElderJames ElderJames enabled auto-merge (squash) August 25, 2022 18:59
@ElderJames ElderJames merged commit 24216bf into ant-design-blazor:master Aug 25, 2022
ElderJames added a commit that referenced this pull request Sep 6, 2022
…ed when not valid. (#2639)

Co-authored-by: James Yeung <shunjiey@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants