Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: form): fix error status for entry components #2647

Merged
merged 1 commit into from
Aug 28, 2022

Conversation

ElderJames
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Aug 28, 2022

@codecov
Copy link

codecov bot commented Aug 28, 2022

Codecov Report

Merging #2647 (8a4b92d) into master (1fc3eea) will increase coverage by 1.52%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master    #2647      +/-   ##
==========================================
+ Coverage   29.96%   31.48%   +1.52%     
==========================================
  Files         505      543      +38     
  Lines       34361    26438    -7923     
  Branches        0      260     +260     
==========================================
- Hits        10296     8325    -1971     
+ Misses      24065    18073    -5992     
- Partials        0       40      +40     
Impacted Files Coverage Δ
components/tree-select/TreeSelect.razor.cs 0.00% <0.00%> (ø)
components/cascader/Cascader.razor.cs 24.21% <100.00%> (+5.25%) ⬆️
components/date-picker/internal/DatePickerBase.cs 63.95% <100.00%> (+3.80%) ⬆️
components/input-number/InputNumber.razor.cs 65.33% <100.00%> (+4.60%) ⬆️
components/core/Helpers/MemberPath/PathNode.cs 46.15% <0.00%> (-8.85%) ⬇️
components/core/Reflection/TypeDefined.cs 77.77% <0.00%> (-7.94%) ⬇️
components/input/InputGroup.razor.cs 87.50% <0.00%> (-6.95%) ⬇️
components/core/Helpers/DateHelper.cs 85.33% <0.00%> (-4.90%) ⬇️
...ponents/date-picker/types/DatePickerPlaceholder.cs 22.72% <0.00%> (-4.20%) ⬇️
...onents/date-picker/internal/DatePickerHeader.razor 41.86% <0.00%> (-3.21%) ⬇️
... and 447 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ElderJames ElderJames merged commit ec4b8dd into master Aug 28, 2022
@ElderJames ElderJames deleted the Private/James/fix-input-control-error-status branch August 28, 2022 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant