Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: avatar): make size parameter support more length unit #2653

Merged
merged 2 commits into from
Sep 1, 2022

Conversation

ElderJames
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English make size parameter support more length unit
🇨🇳 Chinese 让 Size 属性支持各种长度单位

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Aug 31, 2022

@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #2653 (fb814a6) into master (c691eb9) will increase coverage by 1.72%.
The diff coverage is 96.66%.

@@            Coverage Diff             @@
##           master    #2653      +/-   ##
==========================================
+ Coverage   30.24%   31.96%   +1.72%     
==========================================
  Files         505      543      +38     
  Lines       34362    26451    -7911     
  Branches        0      260     +260     
==========================================
- Hits        10394     8456    -1938     
+ Misses      23968    17955    -6013     
- Partials        0       40      +40     
Impacted Files Coverage Δ
components/core/CssSizeLength.cs 86.36% <94.11%> (+53.55%) ⬆️
components/avatar/Avatar.razor.cs 97.43% <100.00%> (-0.55%) ⬇️
components/core/Helpers/MemberPath/PathNode.cs 46.15% <0.00%> (-8.85%) ⬇️
components/avatar/AvatarGroup.razor 75.00% <0.00%> (-8.34%) ⬇️
components/core/Reflection/TypeDefined.cs 77.77% <0.00%> (-7.94%) ⬇️
components/input/InputGroup.razor.cs 87.50% <0.00%> (-6.95%) ⬇️
components/core/Helpers/DateHelper.cs 85.33% <0.00%> (-4.90%) ⬇️
...ponents/date-picker/types/DatePickerPlaceholder.cs 22.72% <0.00%> (-4.20%) ⬇️
...onents/date-picker/internal/DatePickerHeader.razor 41.86% <0.00%> (-3.21%) ⬇️
...ponents/core/Component/Overlay/type/TriggerType.cs 81.25% <0.00%> (-2.97%) ⬇️
... and 445 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ElderJames ElderJames merged commit c8b5215 into master Sep 1, 2022
@ElderJames ElderJames deleted the fix/badge-size-unit branch September 1, 2022 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant