Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module: select): add virtualization support #2654

Conversation

m-khrapunov
Copy link
Contributor

馃 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

#2080

馃挕 Background and solution

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

鈿狅笍 Please check all items below before review. 鈿狅笍

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@dnfadmin
Copy link

dnfadmin commented Aug 31, 2022

CLA assistant check
All CLA requirements met.

@github-actions
Copy link

github-actions bot commented Aug 31, 2022

@ElderJames
Copy link
Member

Thanks for contribute this @m-khrapunov ,it helps a lot!

@codecov
Copy link

codecov bot commented Sep 1, 2022

Codecov Report

Merging #2654 (4879b29) into feature (db291e9) will increase coverage by 1.85%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           feature    #2654      +/-   ##
===========================================
+ Coverage    29.96%   31.82%   +1.85%     
===========================================
  Files          505      543      +38     
  Lines        34364    26535    -7829     
  Branches         0      260     +260     
===========================================
- Hits         10298     8444    -1854     
+ Misses       24066    18051    -6015     
- Partials         0       40      +40     
Impacted Files Coverage 螖
components/select/Select.razor 96.55% <100.00%> (+19.27%) 猬嗭笍
components/select/Select.razor.cs 53.37% <100.00%> (+2.33%) 猬嗭笍
components/core/Helpers/MemberPath/PathNode.cs 46.15% <0.00%> (-8.85%) 猬囷笍
components/core/Reflection/TypeDefined.cs 77.77% <0.00%> (-7.94%) 猬囷笍
components/input/InputGroup.razor.cs 87.50% <0.00%> (-6.95%) 猬囷笍
components/core/Helpers/DateHelper.cs 85.33% <0.00%> (-4.90%) 猬囷笍
...ponents/date-picker/types/DatePickerPlaceholder.cs 22.72% <0.00%> (-4.20%) 猬囷笍
...onents/date-picker/internal/DatePickerHeader.razor 41.86% <0.00%> (-3.21%) 猬囷笍
...ponents/core/Component/Overlay/type/TriggerType.cs 81.25% <0.00%> (-2.97%) 猬囷笍
components/core/Base/AntComponentBase.cs 53.57% <0.00%> (-2.68%) 猬囷笍
... and 445 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ElderJames ElderJames changed the base branch from master to feature September 1, 2022 04:00
@ElderJames ElderJames force-pushed the feat/select/virtualization-support branch from bfcec79 to a0f8045 Compare September 1, 2022 05:45
@ElderJames ElderJames linked an issue Sep 1, 2022 that may be closed by this pull request
Copy link
Member

@ElderJames ElderJames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ElderJames ElderJames merged commit f5b9cd3 into ant-design-blazor:feature Sep 1, 2022
@ElderJames
Copy link
Member

Hi @m-khrapunov ,could you please add virtualizition for more component? Like AntList and Tree

ElderJames added a commit that referenced this pull request Sep 16, 2022
* add virtualization support

* fix doc

Co-authored-by: James Yeung <shunjiey@hotmail.com>
zxyao145 pushed a commit to zxyao145/ant-design-blazor that referenced this pull request Oct 23, 2022
)

* add virtualization support

* fix doc

Co-authored-by: James Yeung <shunjiey@hotmail.com>
ElderJames added a commit that referenced this pull request Oct 19, 2023
* feat(module: select): add virtualization support (#2654)

* add virtualization support

* fix doc

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* add(module: table): filter input focus on dropdown visible

* fix netstandard 2.1 build error

* Revert "fix netstandard 2.1 build error"

This reverts commit 489c50c.

* Revert "add(module: table): filter input focus on dropdown visible"

This reverts commit c0589e3.

* add(module: table): filter input focus on dropdown visible

* clean code format and demo

---------

Co-authored-by: James Yeung <shunjiey@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select component performance
3 participants