Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: select): remove redundant CreateDeleteSelectOptions() calls in render cycles #2657

Conversation

m-khrapunov
Copy link
Contributor

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Sep 1, 2022

@codecov
Copy link

codecov bot commented Sep 1, 2022

Codecov Report

Merging #2657 (959c663) into feature (f5b9cd3) will increase coverage by 1.64%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           feature    #2657      +/-   ##
===========================================
+ Coverage    30.10%   31.74%   +1.64%     
===========================================
  Files          505      543      +38     
  Lines        34459    26535    -7924     
  Branches         0      260     +260     
===========================================
- Hits         10373     8424    -1949     
+ Misses       24086    18071    -6015     
- Partials         0       40      +40     
Impacted Files Coverage Δ
components/select/Select.razor.cs 52.98% <100.00%> (+1.89%) ⬆️
components/core/Helpers/MemberPath/PathNode.cs 46.15% <0.00%> (-8.85%) ⬇️
components/core/Reflection/TypeDefined.cs 77.77% <0.00%> (-7.94%) ⬇️
components/input/InputGroup.razor.cs 87.50% <0.00%> (-6.95%) ⬇️
components/core/Helpers/DateHelper.cs 85.33% <0.00%> (-4.90%) ⬇️
...ponents/date-picker/types/DatePickerPlaceholder.cs 22.72% <0.00%> (-4.20%) ⬇️
...onents/date-picker/internal/DatePickerHeader.razor 41.86% <0.00%> (-3.21%) ⬇️
...ponents/core/Component/Overlay/type/TriggerType.cs 81.25% <0.00%> (-2.97%) ⬇️
components/core/Base/AntComponentBase.cs 53.57% <0.00%> (-2.68%) ⬇️
components/menu/SubMenu.razor 63.93% <0.00%> (-2.30%) ⬇️
... and 444 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@ElderJames ElderJames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ElderJames ElderJames merged commit 00b9462 into ant-design-blazor:feature Sep 1, 2022
ElderJames pushed a commit that referenced this pull request Sep 16, 2022
ElderJames added a commit that referenced this pull request Sep 16, 2022
…ls in render cycles (#2657)

Co-authored-by: m-khrapunov <93575828+m-khrapunov@users.noreply.github.com>
ElderJames pushed a commit that referenced this pull request Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants