Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:(module:datepicker): timepicker value resets to default #2660

Merged

Conversation

Alexbits
Copy link
Contributor

@Alexbits Alexbits commented Sep 2, 2022

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#2637

💡 Background and solution

The Ok button should be preset in the TimePicker or DatePicker with time, as well as the Now button. The Today button should not be shown in the TimePicker. This pull request fixes this.

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Sep 2, 2022

@Alexbits
Copy link
Contributor Author

Alexbits commented Sep 2, 2022

Hey @ElderJames, I believe this should be applied ASAP as a hotfix. This pull request adds missing Ok and Now buttons to the TimePicker. Also, it hides the Today button, which should not be present in TimePIcker. This pull request applies the same TimePicker/DatePicker behavior as in the original ant.design.

@codecov
Copy link

codecov bot commented Sep 2, 2022

Codecov Report

Merging #2660 (672d473) into master (149ff3a) will increase coverage by 1.51%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master    #2660      +/-   ##
==========================================
+ Coverage   30.45%   31.96%   +1.51%     
==========================================
  Files         505      543      +38     
  Lines       34379    26458    -7921     
  Branches        0      260     +260     
==========================================
- Hits        10471     8458    -2013     
+ Misses      23908    17960    -5948     
- Partials        0       40      +40     
Impacted Files Coverage Δ
components/date-picker/internal/DatePickerBase.cs 63.26% <0.00%> (+3.10%) ⬆️
.../date-picker/internal/DatePickerPanelChooser.razor 100.00% <ø> (+18.75%) ⬆️
...date-picker/internal/DatePickerDatetimePanel.razor 70.78% <100.00%> (+4.36%) ⬆️
...e-picker/internal/DatePickerDatetimePanel.razor.cs 74.72% <100.00%> (+10.69%) ⬆️
components/core/Helpers/MemberPath/PathNode.cs 46.15% <0.00%> (-8.85%) ⬇️
components/avatar/AvatarGroup.razor 75.00% <0.00%> (-8.34%) ⬇️
components/core/Reflection/TypeDefined.cs 77.77% <0.00%> (-7.94%) ⬇️
components/input/InputGroup.razor.cs 87.50% <0.00%> (-6.95%) ⬇️
components/core/Helpers/DateHelper.cs 85.33% <0.00%> (-4.90%) ⬇️
...ponents/date-picker/types/DatePickerPlaceholder.cs 22.72% <0.00%> (-4.20%) ⬇️
... and 447 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ElderJames ElderJames merged commit 3e9bb25 into ant-design-blazor:master Sep 2, 2022
@Alexbits Alexbits deleted the fix/time-picker-missing-ok branch September 2, 2022 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants