Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(module: icon): fix two-tone icon state update & first rendering #2666

Merged
merged 5 commits into from
Sep 4, 2022

Conversation

ElderJames
Copy link
Member

@ElderJames ElderJames commented Sep 3, 2022

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fixed #2662

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Sep 3, 2022

@codecov
Copy link

codecov bot commented Sep 3, 2022

Codecov Report

Merging #2666 (45e0029) into master (e9edc35) will increase coverage by 2.88%.
The diff coverage is 41.86%.

@@            Coverage Diff             @@
##           master    #2666      +/-   ##
==========================================
+ Coverage   30.63%   33.52%   +2.88%     
==========================================
  Files         505      543      +38     
  Lines       34369    26450    -7919     
  Branches        0      260     +260     
==========================================
- Hits        10530     8867    -1663     
+ Misses      23839    17543    -6296     
- Partials        0       40      +40     
Impacted Files Coverage Δ
components/icon/IconService.cs 39.53% <39.28%> (+4.34%) ⬆️
components/icon/Icon.razor.cs 75.92% <46.66%> (-4.85%) ⬇️
components/breadcrumb/Breadcrumb.razor.cs 90.00% <0.00%> (-10.00%) ⬇️
components/core/Helpers/MemberPath/PathNode.cs 46.15% <0.00%> (-8.85%) ⬇️
components/avatar/AvatarGroup.razor 75.00% <0.00%> (-8.34%) ⬇️
components/core/Reflection/TypeDefined.cs 77.77% <0.00%> (-7.94%) ⬇️
components/input/InputGroup.razor.cs 87.50% <0.00%> (-6.95%) ⬇️
components/core/Base/AntComponentBase.cs 50.00% <0.00%> (-6.25%) ⬇️
components/core/Helpers/DateHelper.cs 85.33% <0.00%> (-4.90%) ⬇️
...ponents/date-picker/types/DatePickerPlaceholder.cs 22.72% <0.00%> (-4.20%) ⬇️
... and 445 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Sep 4, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@ElderJames ElderJames merged commit 7385f6a into master Sep 4, 2022
@ElderJames ElderJames deleted the refactor/icon-two-tone branch September 4, 2022 02:51
ElderJames added a commit that referenced this pull request Sep 6, 2022
…ing (#2666)

* refactor(module: icon): fix two-tone icon state update & first rendering

* refactor smell code

* fix test packages

* fix smell code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The arrows of Collapse doesn't change regardless if the panel is expanded or collapsed.
1 participant