Refactor IconStore. Add missing icon. Add tests. #2667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
…ts for IconService.
kooliokey
force-pushed
the
pullrequest/refactor-and-test-icons
branch
from
b9264ed
to
8a1d6ab
Compare
Codecov Report
@@ Coverage Diff @@
## master #2667 +/- ##
==========================================
+ Coverage 31.87% 39.97% +8.09%
==========================================
Files 505 543 +38
Lines 34374 25666 -8708
Branches 0 260 +260
==========================================
- Hits 10956 10259 -697
+ Misses 23418 15367 -8051
- Partials 0 40 +40
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ElderJames
approved these changes
Sep 4, 2022
ElderJames
added a commit
that referenced
this pull request
Sep 6, 2022
…tor IconStore. Add tests for IconService. (#2667) Co-authored-by: James Yeung <shunjiey@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
#2644
💡 Background and solution
Refactored icons code to remove having the names of icons in multiple places. All spots now use the class that lists icon names. Used a Lazy object for all icon names to avoid using reflection every time the list is needed.
📝 Changelog
☑️ Self Check before Merge