Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: tabs): panel without animated display incorrectly #2677

Merged
merged 2 commits into from Sep 5, 2022

Conversation

ElderJames
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fixed #2675

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Sep 5, 2022

@codecov
Copy link

codecov bot commented Sep 5, 2022

Codecov Report

Merging #2677 (d0f45b5) into master (b350f13) will increase coverage by 1.27%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2677      +/-   ##
==========================================
+ Coverage   40.14%   41.42%   +1.27%     
==========================================
  Files         505      543      +38     
  Lines       33585    25663    -7922     
  Branches        0      260     +260     
==========================================
- Hits        13483    10630    -2853     
+ Misses      20102    14993    -5109     
- Partials        0       40      +40     
Impacted Files Coverage Δ
components/tabs/TabPane.razor 85.00% <ø> (-0.72%) ⬇️
components/breadcrumb/Breadcrumb.razor.cs 90.00% <0.00%> (-10.00%) ⬇️
components/core/Helpers/MemberPath/PathNode.cs 46.15% <0.00%> (-8.85%) ⬇️
components/avatar/AvatarGroup.razor 75.00% <0.00%> (-8.34%) ⬇️
components/core/Reflection/TypeDefined.cs 77.77% <0.00%> (-7.94%) ⬇️
components/input/InputGroup.razor.cs 87.50% <0.00%> (-6.95%) ⬇️
components/core/Base/AntComponentBase.cs 50.00% <0.00%> (-6.25%) ⬇️
components/core/Helpers/DateHelper.cs 85.33% <0.00%> (-4.90%) ⬇️
...ponents/date-picker/types/DatePickerPlaceholder.cs 22.72% <0.00%> (-4.20%) ⬇️
...onents/date-picker/internal/DatePickerHeader.razor 41.86% <0.00%> (-3.21%) ⬇️
... and 443 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ElderJames ElderJames merged commit 9805945 into master Sep 5, 2022
@ElderJames ElderJames deleted the fix/tab-animated-bug branch September 5, 2022 09:13
ElderJames added a commit that referenced this pull request Sep 6, 2022
* fix(module: tabs): panel without animated display incorrectly

* add test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The rendering of Tabs without Animation is broken
1 participant