fix(module TreeSelect / Tree): search not working on TreeSelect #2686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Trying to change minimum posible to make it work. Add ignoreCase for search on tree and fix display of match to respect the original value.
|
|
Codecov Report
@@ Coverage Diff @@
## master #2686 +/- ##
==========================================
+ Coverage 38.91% 39.95% +1.04%
==========================================
Files 505 543 +38
Lines 33590 25701 -7889
Branches 0 260 +260
==========================================
- Hits 13072 10270 -2802
+ Misses 20518 15391 -5127
- Partials 0 40 +40
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@Magehernan Thanks for contribute this. IMO this is a feature for tree-select. |
|
@ElderJames haha, i wasn't sure and i opted for fix because TreeSelect has EnableSearch but it not work so for that maybe was a fix... i don't know the specification of this feature so maybe it covers the requirements. I hope it helps. |
|
@Magehernan A searching demo for TreeSelect is need. |
|
@ElderJames i added one using the multiple example, i use google translate for chinise translation, please check if it is valid. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
Enabling Search on TreeSelect not working.
💡 Background and solution
When you try to use search on tree select it not work, the code is like the search in select, so base on that i include the part that was missing and make it work.
At the same time i impove the search on tree because it was case sensitive. I make it work with ignore case and found that the code that apply styles to titles was using the input so i change that to use the original value and insert the span with class and style to make it work.
📝 Changelog
Fix search on treeselect
Change tree search to ignoreCase and fix display of match to respect the original value.
☑️ Self Check before Merge