Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: segmentd): default value binding incorrectly with options #2699

Merged
merged 1 commit into from
Sep 12, 2022

Conversation

ElderJames
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Sep 9, 2022

@ElderJames ElderJames changed the title fix(module: segmentd): default value binding incorrectly fix(module: segmentd): default value binding incorrectly with options Sep 9, 2022
@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #2699 (ae2224f) into master (62116f3) will increase coverage by 1.36%.
The diff coverage is 0.00%.

❗ Current head ae2224f differs from pull request most recent head 23afc82. Consider uploading reports for the commit 23afc82 to get more accurate results

@@            Coverage Diff             @@
##           master    #2699      +/-   ##
==========================================
+ Coverage   40.06%   41.42%   +1.36%     
==========================================
  Files         543      543              
  Lines       25674    25668       -6     
  Branches      260      260              
==========================================
+ Hits        10287    10634     +347     
+ Misses      15347    14994     -353     
  Partials       40       40              
Impacted Files Coverage Δ
components/segmented/Segmented.razor.cs 0.00% <0.00%> (ø)
components/core/Component/Overlay/Overlay.razor.cs 67.44% <0.00%> (-6.98%) ⬇️
...nts/core/Component/Overlay/OverlayTrigger.razor.cs 52.63% <0.00%> (-2.64%) ⬇️
components/table/TableModels/SortModel.cs 0.00% <0.00%> (ø)
components/select/Select.razor.cs 53.58% <0.00%> (+0.26%) ⬆️
components/select/SelectBase.cs 71.19% <0.00%> (+0.27%) ⬆️
components/input/Input.cs 67.25% <0.00%> (+0.35%) ⬆️
components/grid/Col.razor.cs 96.00% <0.00%> (+1.33%) ⬆️
components/core/Extensions/JSRuntimeExtensions.cs 53.33% <0.00%> (+3.33%) ⬆️
components/grid/Row.razor.cs 84.44% <0.00%> (+8.88%) ⬆️
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ElderJames ElderJames merged commit 4b4028c into master Sep 12, 2022
@ElderJames ElderJames deleted the fix/segmented/default-value branch September 12, 2022 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant