Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:(module:datepicker): RangePicker has incorrect start/end panels #2707

Merged
merged 6 commits into from
Sep 14, 2022

Conversation

Alexbits
Copy link
Contributor

@Alexbits Alexbits commented Sep 13, 2022

馃 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

#1259

馃挕 Background and solution

This also fixes:
RangePicker end panel not shown in RTL mode
RangePicker range preset value resets when time input is enabled
RangePicker keeps focus when input canceled
RangePicker cannot clear value when one of the inputs has a focus

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

鈿狅笍 Please check all items below before review. 鈿狅笍

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Sep 13, 2022

@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Merging #2707 (57531e7) into master (3949fb9) will decrease coverage by 0.01%.
The diff coverage is 27.08%.

@@            Coverage Diff             @@
##           master    #2707      +/-   ##
==========================================
- Coverage   41.38%   41.36%   -0.02%     
==========================================
  Files         543      543              
  Lines       25698    25692       -6     
  Branches      260      260              
==========================================
- Hits        10634    10628       -6     
  Misses      15024    15024              
  Partials       40       40              
Impacted Files Coverage 螖
components/date-picker/RangePicker.razor 44.00% <酶> (酶)
components/date-picker/internal/DatePickerBase.cs 62.94% <22.50%> (-0.32%) 猬囷笍
components/date-picker/RangePicker.razor.cs 53.98% <50.00%> (-0.08%) 猬囷笍

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@ElderJames ElderJames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ElderJames ElderJames merged commit 504de0d into ant-design-blazor:master Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants