Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use TitleTemplate in Tooltip #2711

Merged
merged 2 commits into from
Sep 16, 2022
Merged

Conversation

CAPCHIK
Copy link
Contributor

@CAPCHIK CAPCHIK commented Sep 14, 2022

I can't be sure of the correctness of the translation into Chinese with the help of a translator, I left places for the Chinese text as TODO: Translate

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

Tooltip component uses OneOf Title instead separated Title and TitleTemplate

📝 Changelog

Users will have to use TitleTemplate if used RenderFragment to Title

Language Changelog
🇺🇸 English Tooltip component uses RenderFragment TitleTeplate instead OneOf Title
🇨🇳 Chinese TODO: Translate

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Sep 14, 2022

@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Merging #2711 (08663a7) into feature (ddf74c6) will decrease coverage by 1.34%.
The diff coverage is 66.66%.

@@             Coverage Diff             @@
##           feature    #2711      +/-   ##
===========================================
- Coverage    41.59%   40.24%   -1.35%     
===========================================
  Files          543      543              
  Lines        25791    25792       +1     
  Branches       260      260              
===========================================
- Hits         10727    10381     -346     
- Misses       15024    15371     +347     
  Partials        40       40              
Impacted Files Coverage Δ
components/tooltip/Tooltip.razor 40.00% <0.00%> (+9.23%) ⬆️
components/menu/MenuItem.razor 95.74% <87.50%> (ø)
components/tooltip/Tooltip.razor.cs 45.00% <100.00%> (+2.89%) ⬆️
components/list/ListItemLayout.cs 0.00% <0.00%> (-100.00%) ⬇️
components/list/ListItem.razor 0.00% <0.00%> (-95.31%) ⬇️
components/list/AntList.razor 0.00% <0.00%> (-92.31%) ⬇️
...omponents/form/Validate/Rule/FormRulesValidator.cs 0.00% <0.00%> (-76.93%) ⬇️
components/list/AntList.razor.cs 0.00% <0.00%> (-76.12%) ⬇️
components/list/ListItem.razor.cs 0.00% <0.00%> (-73.08%) ⬇️
components/form/Form.razor.cs 36.02% <0.00%> (-32.30%) ⬇️
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ElderJames
Copy link
Member

Thank you very much @CAPCHIK ! This help a lot.

@ElderJames ElderJames merged commit 2324347 into ant-design-blazor:feature Sep 16, 2022
zxyao145 pushed a commit to zxyao145/ant-design-blazor that referenced this pull request Oct 23, 2022
…azor#2711)

* Use TitleTemplate in Tooltip

* optimize demo

Co-authored-by: James Yeung <shunjiey@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants