Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: Core): Remove the event listener when the component is disposed #2738

Merged
merged 2 commits into from
Sep 26, 2022

Conversation

ElderJames
Copy link
Member

@ElderJames ElderJames commented Sep 22, 2022

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

follow up #1857

fixed #2136
fixed #2241

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Sep 22, 2022

@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Base: 39.99% // Head: 39.89% // Decreases project coverage by -0.10% ⚠️

Coverage data is based on head (c54eaa5) compared to base (107fc42).
Patch coverage: 1.81% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2738      +/-   ##
==========================================
- Coverage   39.99%   39.89%   -0.11%     
==========================================
  Files         543      544       +1     
  Lines       25697    25720      +23     
  Branches      260      260              
==========================================
- Hits        10278    10261      -17     
- Misses      15379    15419      +40     
  Partials       40       40              
Impacted Files Coverage Δ
...ents/core/Extensions/ElementReferenceExtensions.cs 0.00% <0.00%> (ø)
components/core/JsInterop/DomEventListener.cs 0.00% <0.00%> (ø)
components/core/JsInterop/DomEventSubscription.cs 0.00% <0.00%> (ø)
...mponents/core/JsInterop/modules/dom/eventHelper.ts 4.47% <0.00%> (-0.45%) ⬇️
...omponents/core/JsInterop/modules/dom/infoHelper.ts 37.97% <0.00%> (-0.99%) ⬇️
components/core/JsInterop/JSInteropConstants.cs 28.80% <33.33%> (-0.47%) ⬇️
components/core/Component/Overlay/Overlay.razor.cs 67.44% <0.00%> (-6.98%) ⬇️
...nts/core/Component/Overlay/OverlayTrigger.razor.cs 52.63% <0.00%> (-2.64%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ElderJames ElderJames merged commit d2f95b2 into master Sep 26, 2022
@ElderJames ElderJames deleted the fix/remove-event-listener branch September 26, 2022 02:11
@ElderJames ElderJames mentioned this pull request Sep 26, 2022
@lyj0309 lyj0309 mentioned this pull request Sep 30, 2022
15 tasks
YongQuan-dotnet pushed a commit to YongQuan-dotnet/ant-design-blazor that referenced this pull request Oct 9, 2022
…service is disposed (ant-design-blazor#2738)

* fix(module: Core): Remove the event listener when the component is disaposed

* fix DomEventKey
zxyao145 pushed a commit to zxyao145/ant-design-blazor that referenced this pull request Oct 16, 2022
…service is disposed (ant-design-blazor#2738)

* fix(module: Core): Remove the event listener when the component is disaposed

* fix DomEventKey
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upload componet click remove prompt exception in cosole ReuseTabs close error
1 participant