Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:(module:datepicker): OnChange event behavior is incorrect #2741

Merged

Conversation

Alexbits
Copy link
Contributor

@Alexbits Alexbits commented Sep 22, 2022

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#2713
#2729

💡 Background and solution

This pull request brings DatePicker/RangePicker behavior closer to the behavior of the original ant.design.

📝 Changelog

Fixes:

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Sep 22, 2022

@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Base: 41.34% // Head: 40.13% // Decreases project coverage by -1.20% ⚠️

Coverage data is based on head (fafed92) compared to base (d2f95b2).
Patch coverage: 52.06% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2741      +/-   ##
==========================================
- Coverage   41.34%   40.13%   -1.21%     
==========================================
  Files         544      544              
  Lines       25723    25709      -14     
  Branches      261      261              
==========================================
- Hits        10635    10319     -316     
- Misses      15048    15350     +302     
  Partials       40       40              
Impacted Files Coverage Δ
components/core/Helpers/DateHelper.cs 80.00% <0.00%> (-5.34%) ⬇️
components/date-picker/RangePicker.razor.cs 53.46% <35.00%> (-0.53%) ⬇️
...s/date-picker/internal/DatePickerTemplate.razor.cs 62.68% <50.00%> (ø)
components/date-picker/internal/DatePickerBase.cs 68.96% <56.00%> (+6.01%) ⬆️
components/date-picker/DatePicker.Razor.cs 76.82% <75.47%> (+12.85%) ⬆️
...core/EventCallbackArgs/DateTimeChangedEventArgs.cs 100.00% <100.00%> (+100.00%) ⬆️
...date-picker/internal/DatePickerDatetimePanel.razor 70.78% <100.00%> (ø)
...onents/date-picker/internal/DatePickerPanelBase.cs 57.60% <100.00%> (+1.08%) ⬆️
...omponents/date-picker/internal/DatePickerStatus.cs 100.00% <100.00%> (ø)
components/list/ListItemLayout.cs 0.00% <0.00%> (-100.00%) ⬇️
... and 26 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@ElderJames ElderJames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ElderJames ElderJames merged commit 3b45058 into ant-design-blazor:master Sep 27, 2022
@Alexbits Alexbits deleted the fix/date-picker-onchange branch October 5, 2022 18:26
YongQuan-dotnet pushed a commit to YongQuan-dotnet/ant-design-blazor that referenced this pull request Oct 9, 2022
…sign-blazor#2741)

* refactor:(module:datepicker): DatePickerBase should be abstract

* fix:(module:datepicker): date not highlighted in range picker after ok

* fix:(module:datepicker): OnChange event behavior is incorrect

* fix:(module:datepicker): wrong input panels when start/end same period

* fix:(module:datepicker): ending week is not highlighted correctly

* fix:(module:datepicker): cannot switch year/month in RangePicker header
zxyao145 pushed a commit to zxyao145/ant-design-blazor that referenced this pull request Oct 16, 2022
…sign-blazor#2741)

* refactor:(module:datepicker): DatePickerBase should be abstract

* fix:(module:datepicker): date not highlighted in range picker after ok

* fix:(module:datepicker): OnChange event behavior is incorrect

* fix:(module:datepicker): wrong input panels when start/end same period

* fix:(module:datepicker): ending week is not highlighted correctly

* fix:(module:datepicker): cannot switch year/month in RangePicker header
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants