Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Confirm dialog closeable(#2772) #2776

Merged
merged 1 commit into from
Oct 9, 2022

Conversation

zxyao145
Copy link
Member

@zxyao145 zxyao145 commented Oct 9, 2022

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#2772

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English fix: Confirm dialog closeable
🇨🇳 Chinese Confirm 错误的响应 close icon 事件

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Oct 9, 2022

@codecov
Copy link

codecov bot commented Oct 9, 2022

Codecov Report

Base: 40.20% // Head: 40.13% // Decreases project coverage by -0.07% ⚠️

Coverage data is based on head (22c9ef5) compared to base (6606034).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2776      +/-   ##
==========================================
- Coverage   40.20%   40.13%   -0.08%     
==========================================
  Files         544      544              
  Lines       25707    25708       +1     
  Branches      261      261              
==========================================
- Hits        10336    10317      -19     
- Misses      15331    15351      +20     
  Partials       40       40              
Impacted Files Coverage Δ
components/modal/confirmDialog/Confirm.razor.cs 0.00% <0.00%> (ø)
components/core/Component/Overlay/Overlay.razor.cs 69.18% <0.00%> (-6.98%) ⬇️
components/core/Base/AntComponentBase.cs 53.57% <0.00%> (-3.58%) ⬇️
...nts/core/Component/Overlay/OverlayTrigger.razor.cs 52.63% <0.00%> (-2.64%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ElderJames ElderJames merged commit 293920b into ant-design-blazor:master Oct 9, 2022
zxyao145 added a commit to zxyao145/ant-design-blazor that referenced this pull request Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The close icon does not appear in the upper-right corner of the modal box, but it can actually be turned off
2 participants