Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: segmented): The Disabled parameter does not work on items and cannot be dynamically toggled #2778

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

ElderJames
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fixed #2760

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fixed Segmented that the Disabled parameter does not work on items and cannot be dynamically toggled
🇨🇳 Chinese 修复 Segmented 的 Disabled 参数对项不起作用,也不能动态切换的问题

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

Prepare preview

@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Base: 40.15% // Head: 41.58% // Increases project coverage by +1.43% 🎉

Coverage data is based on head (698991d) compared to base (1a90a3b).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2778      +/-   ##
==========================================
+ Coverage   40.15%   41.58%   +1.43%     
==========================================
  Files         544      544              
  Lines       25708    25715       +7     
  Branches      261      261              
==========================================
+ Hits        10322    10694     +372     
+ Misses      15346    14981     -365     
  Partials       40       40              
Impacted Files Coverage Δ
components/segmented/Segmented.razor.cs 0.00% <0.00%> (ø)
components/segmented/SegmentedItem.razor.cs 0.00% <0.00%> (ø)
components/select/Select.razor.cs 53.18% <0.00%> (+0.26%) ⬆️
components/select/SelectBase.cs 71.19% <0.00%> (+0.27%) ⬆️
components/input/Input.cs 67.25% <0.00%> (+0.35%) ⬆️
components/date-picker/DatePicker.Razor.cs 77.48% <0.00%> (+0.66%) ⬆️
components/grid/Col.razor.cs 96.00% <0.00%> (+1.33%) ⬆️
components/date-picker/internal/DatePickerBase.cs 70.57% <0.00%> (+1.60%) ⬆️
components/core/Extensions/JSRuntimeExtensions.cs 53.33% <0.00%> (+3.33%) ⬆️
components/grid/Row.razor.cs 84.44% <0.00%> (+8.88%) ⬆️
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ElderJames ElderJames merged commit f7c1e5f into master Oct 11, 2022
@ElderJames ElderJames deleted the fix/segmented-disabled branch October 11, 2022 01:21
zxyao145 pushed a commit to zxyao145/ant-design-blazor that referenced this pull request Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segmented component Disabled error
2 participants