Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: Cascader) AllowClear was not working when false #2792

Merged
merged 1 commit into from
Oct 13, 2022

Conversation

YongQuan-dotnet
Copy link
Collaborator

@YongQuan-dotnet YongQuan-dotnet commented Oct 12, 2022

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Oct 12, 2022

@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Base: 41.59% // Head: 40.14% // Decreases project coverage by -1.44% ⚠️

Coverage data is based on head (0cdd5a3) compared to base (bed2028).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2792      +/-   ##
==========================================
- Coverage   41.59%   40.14%   -1.45%     
==========================================
  Files         544      544              
  Lines       25712    25716       +4     
  Branches      260      260              
==========================================
- Hits        10694    10324     -370     
- Misses      14978    15352     +374     
  Partials       40       40              
Impacted Files Coverage Δ
components/cascader/Cascader.razor 80.44% <100.00%> (+0.10%) ⬆️
components/list/ListItemLayout.cs 0.00% <0.00%> (-100.00%) ⬇️
components/list/ListItem.razor 0.00% <0.00%> (-95.31%) ⬇️
components/list/AntList.razor 0.00% <0.00%> (-92.31%) ⬇️
...omponents/form/Validate/Rule/FormRulesValidator.cs 0.00% <0.00%> (-76.93%) ⬇️
components/list/AntList.razor.cs 0.00% <0.00%> (-76.12%) ⬇️
components/list/ListItem.razor.cs 0.00% <0.00%> (-73.08%) ⬇️
components/form/Form.razor.cs 36.02% <0.00%> (-32.30%) ⬇️
components/form/FormItem.razor.cs 43.31% <0.00%> (-29.94%) ⬇️
components/form/Form.razor 71.42% <0.00%> (-28.58%) ⬇️
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@YongQuan-dotnet YongQuan-dotnet force-pushed the fix/cascader branch 2 times, most recently from 577c433 to ccc490c Compare October 13, 2022 07:34
@ElderJames ElderJames merged commit 7ff7f0e into ant-design-blazor:master Oct 13, 2022
zxyao145 pushed a commit to zxyao145/ant-design-blazor that referenced this pull request Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants