Update Table.razor.cs #2797
Merged
Update Table.razor.cs #2797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In DisposeAsync() Method of Tab.razor.cs, I add a try - catch around the JSInterop call method "await JsInvokeAsync(JSInteropConstants.UnbindTableScroll, _tableBodyRef);" in order to prevent some error and warning entry in the Windows Event Viewer.
|
|
|
|
AntoninLem
approved these changes
Oct 13, 2022
AntoninLem
approved these changes
Oct 13, 2022
ElderJames
added
PR: reviewed-changes-requested
and removed
PR: reviewed-approved
labels
Codecov ReportBase: 41.59% // Head: 41.63% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2797 +/- ##
==========================================
+ Coverage 41.59% 41.63% +0.04%
==========================================
Files 544 544
Lines 25712 25740 +28
Branches 260 260
==========================================
+ Hits 10694 10718 +24
- Misses 14978 14982 +4
Partials 40 40
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. β View full report at Codecov. |
ElderJames
approved these changes
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π€ This is a ...
π Related issue link
#2794
π‘ Background and solution
Here the details of the Error:
Category: Microsoft.AspNetCore.Components.Server.Circuits.RemoteRenderer
EventId: 100
Unhandled exception rendering component: JavaScript interop calls cannot be issued at this time. This is because the circuit has disconnected and is being disposed.
Exception:
Microsoft.JSInterop.JSDisconnectedException: JavaScript interop calls cannot be issued at this time. This is because the circuit has disconnected and is being disposed.
at Microsoft.AspNetCore.Components.Server.Circuits.RemoteJSRuntime.BeginInvokeJS(Int64 asyncHandle, String identifier, String argsJson, JSCallResultType resultType, Int64 targetInstanceId)
at Microsoft.JSInterop.JSRuntime.InvokeAsync[TValue](Int64 targetInstanceId, String identifier, CancellationToken cancellationToken, Object[] args)
at Microsoft.JSInterop.JSRuntime.InvokeAsync[TValue](Int64 targetInstanceId, String identifier, Object[] args)
at Microsoft.JSInterop.JSRuntimeExtensions.InvokeVoidAsync(IJSRuntime jsRuntime, String identifier, Object[] args)
at AntDesign.AntComponentBase.JsInvokeAsync(String code, Object[] args)
at AntDesign.Table`1.DisposeAsync()
at Microsoft.AspNetCore.Components.RenderTree.Renderer.<>c__DisplayClass69_0.<g__HandleAsyncExceptions|1>d.MoveNext()
Our apps run in .NET 6.0, with Visual Studio 2022, in Blazor Server and 0.12.5 package version of Ant-Design-Blazor.
For information, it's not an issue you can see in your apps, even our logging error system doesn't see it. It occured when SignalR connection is disconnected. As we can see in the error details, it happened because of the method DisposeAsync() of the component Table. After a quick check, we can see that in this method we can foud in Table.razor.cs, there is a call to a jsInterop method.
In DisposeAsync() Method of Tab.razor.cs, I add a try - catch around the JSInterop call method "await JsInvokeAsync(JSInteropConstants.UnbindTableScroll, _tableBodyRef);" in order to prevent some error and warning entry in the Windows Event Viewer.
π Changelog
There is no changes from userside