Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: descriptions): add missing div element #2798

Merged
merged 1 commit into from
Oct 13, 2022

Conversation

weilence
Copy link
Contributor

@weilence weilence commented Oct 12, 2022

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

Currenttly, it's lose div.ant-descriptions-item-container element
Sync dom structure with ant design framework link
image

📝 Changelog

Language Changelog
🇺🇸 English fix descriptions component miss div element
🇨🇳 Chinese 修复描述列表组件缺少的div元素

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

Prepare preview

@dnfadmin
Copy link

dnfadmin commented Oct 12, 2022

CLA assistant check
All CLA requirements met.

@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Base: 41.59% // Head: 41.57% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (0b895f3) compared to base (bed2028).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2798      +/-   ##
==========================================
- Coverage   41.59%   41.57%   -0.02%     
==========================================
  Files         544      544              
  Lines       25712    25712              
  Branches      260      260              
==========================================
- Hits        10694    10691       -3     
- Misses      14978    14981       +3     
  Partials       40       40              
Impacted Files Coverage Δ
components/descriptions/Descriptions.razor 0.00% <0.00%> (ø)
components/core/Component/Overlay/Overlay.razor.cs 69.18% <0.00%> (-1.17%) ⬇️
components/date-picker/RangePicker.razor.cs 53.46% <0.00%> (-0.34%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@ElderJames ElderJames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ElderJames ElderJames merged commit 4bcb923 into ant-design-blazor:master Oct 13, 2022
zxyao145 pushed a commit to zxyao145/ant-design-blazor that referenced this pull request Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants