Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(modal): add only one OK footer and onlt one Cancel footer #2812

Conversation

zxyao145
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#2769

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English feat(modal): add only one OK footer and onlt one Cancel footer
🇨🇳 Chinese 为 Modal 内置仅有一个 OK 按钮的 Footer 和仅有一个 Cancel 按钮的 Footer

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Oct 15, 2022

@codecov
Copy link

codecov bot commented Oct 15, 2022

Codecov Report

Base: 40.22% // Head: 40.20% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (13b7df6) compared to base (ba47536).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           feature    #2812      +/-   ##
===========================================
- Coverage    40.22%   40.20%   -0.03%     
===========================================
  Files          545      549       +4     
  Lines        25829    25845      +16     
  Branches       261      261              
===========================================
  Hits         10391    10391              
- Misses       15398    15414      +16     
  Partials        40       40              
Impacted Files Coverage Δ
components/modal/config/ModalOptions.cs 0.00% <ø> (ø)
components/modal/core/Dialog.razor.cs 0.00% <ø> (ø)
...mponents/modal/modalDialog/ModalCancelFooter.razor 0.00% <0.00%> (ø)
...nents/modal/modalDialog/ModalCancelFooter.razor.cs 0.00% <0.00%> (ø)
components/modal/modalDialog/ModalFooter.razor.cs 0.00% <0.00%> (ø)
components/modal/modalDialog/ModalOkFooter.razor 0.00% <0.00%> (ø)
...omponents/modal/modalDialog/ModalOkFooter.razor.cs 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ElderJames
Copy link
Member

@zxyao145 Please rebase to feature branch. Thank you!

@zxyao145 zxyao145 force-pushed the feat/modal-only-okorcancel-btn-2769 branch from e066c5a to 726ad13 Compare October 16, 2022 08:38
@zxyao145 zxyao145 changed the base branch from master to feature October 16, 2022 08:39
@zxyao145
Copy link
Member Author

@zxyao145 Please rebase to feature branch. Thank you!

done

@zxyao145 zxyao145 force-pushed the feat/modal-only-okorcancel-btn-2769 branch from 9fcf667 to 07bb42b Compare October 22, 2022 15:36
@zxyao145
Copy link
Member Author

@ElderJames Hi, demo has been updated.

@ElderJames ElderJames force-pushed the feat/modal-only-okorcancel-btn-2769 branch from 07bb42b to 13b7df6 Compare October 23, 2022 00:47
@ElderJames ElderJames merged commit 3b5070a into ant-design-blazor:feature Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants