Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:button): Add DownloadButton #2819

Merged
merged 4 commits into from
Oct 21, 2022
Merged

feat(module:button): Add DownloadButton #2819

merged 4 commits into from
Oct 21, 2022

Conversation

LeaFrock
Copy link
Contributor

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

Close #2293

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Add DownloadButton
🇨🇳 Chinese 新增DownloadButton

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Oct 19, 2022

@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Base: 40.24% // Head: 40.29% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (24d19db) compared to base (421b76e).
Patch coverage: 30.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           feature    #2819      +/-   ##
===========================================
+ Coverage    40.24%   40.29%   +0.05%     
===========================================
  Files          543      545       +2     
  Lines        25807    25829      +22     
  Branches       260      261       +1     
===========================================
+ Hits         10385    10408      +23     
+ Misses       15382    15381       -1     
  Partials        40       40              
Impacted Files Coverage Δ
components/core/JsInterop/interop.ts 0.00% <ø> (ø)
...ore/JsInterop/modules/components/downloadHelper.ts 0.00% <0.00%> (ø)
components/button/DownloadButton.razor.cs 33.33% <33.33%> (ø)
components/core/JsInterop/JSInteropConstants.cs 30.40% <100.00%> (+1.13%) ⬆️
components/drawer/Drawer.razor.cs 0.00% <0.00%> (ø)
components/drawer/DrawerContainer.razor 0.00% <0.00%> (ø)
components/drawer/config/DrawerOptions.cs 0.00% <0.00%> (ø)
...nts/core/Component/Overlay/OverlayTrigger.razor.cs 55.49% <0.00%> (+2.61%) ⬆️
components/core/Component/Overlay/Overlay.razor.cs 74.41% <0.00%> (+6.97%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ElderJames ElderJames merged commit ba47536 into ant-design-blazor:feature Oct 21, 2022
zxyao145 pushed a commit to zxyao145/ant-design-blazor that referenced this pull request Oct 23, 2022
* Add `DownloadButton`

* Add doc for `DownloadButton`

* Remove an unnecessary file

* impore doc

Co-authored-by: James Yeung <shunjiey@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants