Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(module: badge): Test Badge component, format document, fix small bug with class name #2830

Merged
merged 2 commits into from
Oct 22, 2022

Conversation

kooliokey
Copy link
Contributor

@kooliokey kooliokey commented Oct 21, 2022

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix bug where Title parameter was not being rendered.
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Oct 21, 2022

kooliokey added 2 commits October 21, 2022 19:22
…settings. Small bug fix for invalid class showing when custom color is set.
@codecov
Copy link

codecov bot commented Oct 21, 2022

Codecov Report

Base: 41.18% // Head: 41.71% // Increases project coverage by +0.52% 🎉

Coverage data is based on head (a7e9244) compared to base (9dcfb28).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2830      +/-   ##
==========================================
+ Coverage   41.18%   41.71%   +0.52%     
==========================================
  Files         544      544              
  Lines       25763    25772       +9     
  Branches      260      260              
==========================================
+ Hits        10611    10751     +140     
+ Misses      15112    14981     -131     
  Partials       40       40              
Impacted Files Coverage Δ
components/badge/Badge.razor 95.00% <100.00%> (+95.00%) ⬆️
components/badge/Badge.razor.cs 88.88% <100.00%> (+88.88%) ⬆️
components/date-picker/DatePicker.Razor.cs 76.82% <0.00%> (-0.67%) ⬇️
components/date-picker/RangePicker.razor.cs 53.79% <0.00%> (+0.33%) ⬆️
...nts/core/Component/Overlay/OverlayTrigger.razor.cs 55.26% <0.00%> (+2.63%) ⬆️
components/core/Component/Overlay/Overlay.razor.cs 83.72% <0.00%> (+6.97%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@ElderJames ElderJames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ElderJames ElderJames merged commit f9c5f5c into ant-design-blazor:master Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants