Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: backtop): doesn't remove the dom when visible is false #2831

Merged
merged 3 commits into from
Oct 24, 2022

Conversation

ElderJames
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English fix backtop doesn't remove the dom when visible is false
🇨🇳 Chinese 修复 BackTop 在隐藏时没有真正清除 dom

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Oct 23, 2022

@codecov
Copy link

codecov bot commented Oct 23, 2022

Codecov Report

Base: 41.18% // Head: 43.20% // Increases project coverage by +2.01% 🎉

Coverage data is based on head (8a41235) compared to base (9dcfb28).
Patch coverage: 31.25% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2831      +/-   ##
==========================================
+ Coverage   41.18%   43.20%   +2.01%     
==========================================
  Files         544      544              
  Lines       25763    25777      +14     
  Branches      260      260              
==========================================
+ Hits        10611    11136     +525     
+ Misses      15112    14601     -511     
  Partials       40       40              
Impacted Files Coverage Δ
components/back-top/BackTop.razor.cs 55.31% <8.33%> (+55.31%) ⬆️
components/back-top/BackTop.razor 100.00% <100.00%> (+100.00%) ⬆️
components/select/Select.razor.cs 53.18% <0.00%> (+0.26%) ⬆️
components/select/SelectBase.cs 71.19% <0.00%> (+0.27%) ⬆️
components/date-picker/RangePicker.razor.cs 53.79% <0.00%> (+0.33%) ⬆️
components/input/Input.cs 67.25% <0.00%> (+0.35%) ⬆️
components/core/CssSizeLength.cs 86.07% <0.00%> (+1.07%) ⬆️
components/grid/Col.razor.cs 96.00% <0.00%> (+1.33%) ⬆️
components/date-picker/internal/DatePickerBase.cs 70.57% <0.00%> (+1.60%) ⬆️
components/core/Extensions/JSRuntimeExtensions.cs 53.33% <0.00%> (+3.33%) ⬆️
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ElderJames ElderJames merged commit 97fdc2a into master Oct 24, 2022
@ElderJames ElderJames deleted the fix/backtop-visible branch October 24, 2022 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant