Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/modal maximization in initialize #2834

Conversation

zxyao145
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#2823

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English support the maximization of Modal initialization
🇨🇳 Chinese 支持 Modal 初始化的时候最大化

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Oct 23, 2022

@codecov
Copy link

codecov bot commented Oct 23, 2022

Codecov Report

Base: 40.35% // Head: 41.78% // Increases project coverage by +1.43% 🎉

Coverage data is based on head (5b9ce81) compared to base (7ad1566).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           feature    #2834      +/-   ##
===========================================
+ Coverage    40.35%   41.78%   +1.43%     
===========================================
  Files          545      545              
  Lines        25818    25822       +4     
  Branches       262      262              
===========================================
+ Hits         10418    10791     +373     
+ Misses       15360    14991     -369     
  Partials        40       40              
Impacted Files Coverage Δ
components/modal/config/DialogOptions.cs 0.00% <0.00%> (ø)
components/modal/config/ModalOptions.cs 0.00% <0.00%> (ø)
components/modal/core/Dialog.razor.cs 0.00% <0.00%> (ø)
components/modal/modalDialog/Modal.razor.cs 0.00% <0.00%> (ø)
components/modal/modalDialog/ModalContainer.razor 0.00% <0.00%> (ø)
components/core/Base/AntComponentBase.cs 50.00% <0.00%> (-3.58%) ⬇️
components/select/Select.razor.cs 53.24% <0.00%> (+0.26%) ⬆️
components/select/SelectBase.cs 71.19% <0.00%> (+0.27%) ⬆️
components/input/Input.cs 69.12% <0.00%> (+0.35%) ⬆️
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ElderJames ElderJames force-pushed the feat/modal-maximization-in-initialize branch from 6f459bd to 5b9ce81 Compare November 14, 2022 05:51
@ElderJames ElderJames merged commit 0ed2da0 into ant-design-blazor:feature Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants