Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:(module: datepicker): add OnOk event #2840

Merged
merged 5 commits into from
Oct 31, 2022

Conversation

Alexbits
Copy link
Contributor

@Alexbits Alexbits commented Oct 26, 2022

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#2307

💡 Background and solution

📝 Changelog

This pull request adds the OnOk event to the DatePicker/RangePicker (with time). The event is invoked when the value input is confirmed with the Ok button.

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Oct 26, 2022

@Alexbits
Copy link
Contributor Author

Hey @ElderJames I think we should rename the OnClearClick event to OnClear to be consistent with OnOk. Or OnOk to OnOkClick? It's OnOk in the original ant.design. What do you think?

@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Base: 41.66% // Head: 40.37% // Decreases project coverage by -1.28% ⚠️

Coverage data is based on head (f313f75) compared to base (2a59463).
Patch coverage: 91.30% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           feature    #2840      +/-   ##
===========================================
- Coverage    41.66%   40.37%   -1.29%     
===========================================
  Files          545      545              
  Lines        25832    25852      +20     
  Branches       261      261              
===========================================
- Hits         10762    10438     -324     
- Misses       15030    15374     +344     
  Partials        40       40              
Impacted Files Coverage Δ
components/date-picker/internal/DatePickerBase.cs 62.74% <50.00%> (-0.20%) ⬇️
...core/EventCallbackArgs/DateTimeChangedEventArgs.cs 100.00% <100.00%> (+100.00%) ⬆️
components/date-picker/DatePicker.Razor.cs 65.95% <100.00%> (+1.98%) ⬆️
components/date-picker/RangePicker.razor.cs 55.52% <100.00%> (+1.53%) ⬆️
components/list/ListItemLayout.cs 0.00% <0.00%> (-100.00%) ⬇️
components/list/ListItem.razor 0.00% <0.00%> (-95.31%) ⬇️
components/list/AntList.razor 0.00% <0.00%> (-92.31%) ⬇️
...omponents/form/Validate/Rule/FormRulesValidator.cs 0.00% <0.00%> (-76.93%) ⬇️
components/list/AntList.razor.cs 0.00% <0.00%> (-76.12%) ⬇️
components/list/ListItem.razor.cs 0.00% <0.00%> (-73.08%) ⬇️
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ElderJames
Copy link
Member

Hey @ElderJames I think we should rename the OnClearClick event to OnClear to be consistent with OnOk. Or OnOk to OnOkClick? It's OnOk in the original ant.design. What do you think?

We align with ant.design

@ElderJames
Copy link
Member

@Alexbits Thank you! But I think we need to keep the old parameter for several release.And please change the target branch to feature.

@Alexbits Alexbits changed the base branch from master to feature October 26, 2022 13:58
@Alexbits
Copy link
Contributor Author

Alexbits commented Oct 26, 2022

@Alexbits Thank you! But I think we need to keep the old parameter for several release.And please change the target branch to feature.

@ElderJames Changed to feature. Should I rename OnClear back to OnClearClick?

@ElderJames
Copy link
Member

No, just keep it and add the [Obsolete] attribute.

@ElderJames ElderJames merged commit 594c5f3 into ant-design-blazor:feature Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants