-
-
Notifications
You must be signed in to change notification settings - Fork 999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:(module: datepicker): add OnOk event #2840
feat:(module: datepicker): add OnOk event #2840
Conversation
Hey @ElderJames I think we should rename the OnClearClick event to OnClear to be consistent with OnOk. Or OnOk to OnOkClick? It's OnOk in the original ant.design. What do you think? |
Codecov ReportBase: 41.66% // Head: 40.37% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## feature #2840 +/- ##
===========================================
- Coverage 41.66% 40.37% -1.29%
===========================================
Files 545 545
Lines 25832 25852 +20
Branches 261 261
===========================================
- Hits 10762 10438 -324
- Misses 15030 15374 +344
Partials 40 40
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
We align with ant.design |
@Alexbits Thank you! But I think we need to keep the old parameter for several release.And please change the target branch to |
@ElderJames Changed to feature. Should I rename OnClear back to OnClearClick? |
No, just keep it and add the |
f9029ab
to
f313f75
Compare
🤔 This is a ...
🔗 Related issue link
#2307
💡 Background and solution
📝 Changelog
This pull request adds the OnOk event to the DatePicker/RangePicker (with time). The event is invoked when the value input is confirmed with the Ok button.
☑️ Self Check before Merge