Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: input): convert error status work incorrectly #2846

Merged
merged 2 commits into from
Oct 31, 2022

Conversation

ElderJames
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fixed #2763

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Oct 30, 2022

@codecov
Copy link

codecov bot commented Oct 30, 2022

Codecov Report

Base: 41.66% // Head: 41.75% // Increases project coverage by +0.09% 🎉

Coverage data is based on head (53f12da) compared to base (2a59463).
Patch coverage: 90.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           feature    #2846      +/-   ##
===========================================
+ Coverage    41.66%   41.75%   +0.09%     
===========================================
  Files          545      545              
  Lines        25832    25848      +16     
  Branches       261      261              
===========================================
+ Hits         10762    10792      +30     
+ Misses       15030    15016      -14     
  Partials        40       40              
Impacted Files Coverage Δ
components/input/Input.cs 69.12% <87.50%> (-0.11%) ⬇️
components/core/Base/AntInputComponentBase.cs 80.95% <100.00%> (+7.61%) ⬆️
components/form/FormItem.razor.cs 73.24% <100.00%> (ø)
components/date-picker/internal/DatePickerBase.cs 62.74% <0.00%> (-0.20%) ⬇️
components/date-picker/RangePicker.razor.cs 55.52% <0.00%> (+1.53%) ⬆️
components/date-picker/DatePicker.Razor.cs 65.95% <0.00%> (+1.98%) ⬆️
components/core/Base/AntComponentBase.cs 53.57% <0.00%> (+3.57%) ⬆️
...core/EventCallbackArgs/DateTimeChangedEventArgs.cs 100.00% <0.00%> (+100.00%) ⬆️
...ore/EventCallbackArgs/DateRangeChangedEventArgs.cs 100.00% <0.00%> (+100.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ElderJames ElderJames linked an issue Oct 31, 2022 that may be closed by this pull request
@ElderJames ElderJames merged commit 1828406 into feature Oct 31, 2022
@ElderJames ElderJames deleted the fix/input/convert-error-status branch October 31, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Input: is this a bug?
1 participant