Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:(module: datepicker): tab key does not confirm the value #2847

Conversation

Alexbits
Copy link
Contributor

@Alexbits Alexbits commented Oct 30, 2022

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#2841

💡 Background and solution

This fixes two issues from #2841.

Also, it brings RangePicker's behavior closer to the original antdesign. It gives the ability to select the range values more conveniently. Now it's possible to select the start date later than the end date without clearing the value.

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Oct 30, 2022

@codecov
Copy link

codecov bot commented Oct 30, 2022

Codecov Report

Base: 43.89% // Head: 44.15% // Increases project coverage by +0.26% 🎉

Coverage data is based on head (dbe1333) compared to base (fc91fb9).
Patch coverage: 76.38% of modified lines in pull request are covered.

❗ Current head dbe1333 differs from pull request most recent head a0b91fe. Consider uploading reports for the commit a0b91fe to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2847      +/-   ##
==========================================
+ Coverage   43.89%   44.15%   +0.26%     
==========================================
  Files         544      544              
  Lines       25757    25747      -10     
  Branches      260      260              
==========================================
+ Hits        11305    11369      +64     
+ Misses      14412    14338      -74     
  Partials       40       40              
Impacted Files Coverage Δ
components/date-picker/RangePicker.razor.cs 65.10% <68.29%> (+11.63%) ⬆️
components/date-picker/DatePicker.Razor.cs 80.98% <81.25%> (+3.50%) ⬆️
components/date-picker/internal/DatePickerBase.cs 78.82% <93.33%> (+8.25%) ⬆️
components/core/Component/Overlay/Overlay.razor.cs 73.83% <0.00%> (-1.75%) ⬇️
components/tabs/Tabs.razor.cs 69.84% <0.00%> (-0.94%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ElderJames
Copy link
Member

Could we also support the short cut for date/month/year navigate?

@Alexbits
Copy link
Contributor Author

Could we also support the short cut for date/month/year navigate?

@ElderJames What shortcut do you mean?

@ElderJames
Copy link
Member

@Alexbits Just use keyboard to choose date

@ElderJames ElderJames linked an issue Nov 1, 2022 that may be closed by this pull request
@ElderJames ElderJames enabled auto-merge (squash) November 1, 2022 04:07
@ElderJames ElderJames merged commit 29143db into ant-design-blazor:master Nov 1, 2022
@Alexbits
Copy link
Contributor Author

Alexbits commented Nov 1, 2022

@Alexbits Just use keyboard to choose date

@ElderJames The tab key should move the input focus to the datetimepanel, and this should allow selecting days with the keyboard. I will look into this later.

@ElderJames
Copy link
Member

@Alexbits That's great! Thank you.

@YingXiaoMing
Copy link

this

how to use focus, it press tab can skip,the datepicker be empty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Found two bugs with Datepick when typing
3 participants