Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:(module:datepicker): smoothScrollTo causes an infinite loop #2854

Merged

Conversation

Alexbits
Copy link
Contributor

@Alexbits Alexbits commented Nov 3, 2022

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

The smoothScrollTo function continued to loop when it shouldn't causing various issues with the selected time animation in the DatePicker/RangePicker with time input. I replaced it with the ts function from the picker used in the ant.design. This issue should be hot-fixed ASAP.

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Nov 3, 2022

@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Base: 42.81% // Head: 44.17% // Increases project coverage by +1.35% 🎉

Coverage data is based on head (dcdab18) compared to base (674753c).
Patch coverage: 12.50% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2854      +/-   ##
==========================================
+ Coverage   42.81%   44.17%   +1.35%     
==========================================
  Files         544      544              
  Lines       25756    25755       -1     
  Branches      260      261       +1     
==========================================
+ Hits        11028    11376     +348     
+ Misses      14688    14339     -349     
  Partials       40       40              
Impacted Files Coverage Δ
...s/core/JsInterop/modules/dom/manipulationHelper.ts 14.03% <6.66%> (+0.34%) ⬆️
...e-picker/internal/DatePickerDatetimePanel.razor.cs 74.72% <100.00%> (ø)
components/core/Component/Overlay/Overlay.razor.cs 73.83% <0.00%> (-8.73%) ⬇️
...nts/core/Component/Overlay/OverlayTrigger.razor.cs 52.63% <0.00%> (-2.64%) ⬇️
components/select/Select.razor.cs 53.18% <0.00%> (+0.26%) ⬆️
components/select/SelectBase.cs 71.19% <0.00%> (+0.27%) ⬆️
components/input/Input.cs 67.25% <0.00%> (+0.35%) ⬆️
components/date-picker/internal/DatePickerBase.cs 78.82% <0.00%> (+0.67%) ⬆️
components/core/CssSizeLength.cs 86.07% <0.00%> (+1.07%) ⬆️
components/grid/Col.razor.cs 96.00% <0.00%> (+1.33%) ⬆️
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@ElderJames ElderJames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@ElderJames ElderJames merged commit 8e7405e into ant-design-blazor:master Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants