Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: upload): should get error raw response #2858

Merged

Conversation

yosheng
Copy link
Contributor

@yosheng yosheng commented Nov 4, 2022

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#2857

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Nov 4, 2022

@dnfadmin
Copy link

dnfadmin commented Nov 4, 2022

CLA assistant check
All CLA requirements met.

@yosheng yosheng changed the title fix(module: upload): should get error raw response #2857 fix(module: upload): should get error raw response Nov 4, 2022
@ElderJames
Copy link
Member

Thanks for contribution @yosheng , please help us to confirm if it solve your issue.

@yosheng
Copy link
Contributor Author

yosheng commented Nov 4, 2022

Thanks for contribution @yosheng , please help us to confirm if it solve your issue.

sure! @ElderJames

@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Base: 44.21% // Head: 44.25% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (e1227af) compared to base (609f14b).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2858      +/-   ##
==========================================
+ Coverage   44.21%   44.25%   +0.04%     
==========================================
  Files         545      545              
  Lines       25771    25771              
  Branches      261      261              
==========================================
+ Hits        11394    11406      +12     
+ Misses      14337    14325      -12     
  Partials       40       40              
Impacted Files Coverage Δ
.../core/JsInterop/modules/components/uploadHelper.ts 0.00% <0.00%> (ø)
components/date-picker/locale/DatePickerLocale.cs 100.00% <0.00%> (+3.22%) ⬆️
components/locale-provider/LocaleProvider.cs 66.66% <0.00%> (+12.82%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yosheng
Copy link
Contributor Author

yosheng commented Nov 4, 2022

@ElderJames how colud i fix this "Added line #L76 was not covered by tests" ? After looking through the project I don't know how to add unit tests

@ElderJames
Copy link
Member

You can ignore this warning.

@ElderJames ElderJames merged commit 26c0c33 into ant-design-blazor:master Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OnCompleted of upload with InternalServerError couldn't get reponse body
3 participants