should solve #2863 #2864
Merged
should solve #2863 #2864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
|
Thanks for contribution @AndrewKaninchen , you can test it on the preview site. 😊 |
Codecov ReportBase: 42.78% // Head: 42.84% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2864 +/- ##
==========================================
+ Coverage 42.78% 42.84% +0.06%
==========================================
Files 545 545
Lines 25775 25777 +2
Branches 261 261
==========================================
+ Hits 11027 11044 +17
+ Misses 14708 14693 -15
Partials 40 40
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should solve #2863
I couldn't test it, but it should work if the underlying code works.
If it does, the example code on the website can be changed to implement dropping, which should be pretty straightforward.