Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor mentions #2874

Merged
merged 4 commits into from
Nov 13, 2022
Merged

refactor mentions #2874

merged 4 commits into from
Nov 13, 2022

Conversation

dingyanwu
Copy link
Contributor

@dingyanwu dingyanwu commented Nov 10, 2022

🤔 这个变动的性质是?

  • 新特性提交
  • 日常 bug 修复
  • 站点、文档改进
  • 演示代码改进
  • 组件样式改进
  • 包体积优化
  • 性能优化
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

💡 需求背景和解决方案

原版mentions没有自动过滤、上下键选择、回车键确认,重构以实现上述功能。

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • Changelog 已提供或无须提供

@github-actions
Copy link

github-actions bot commented Nov 10, 2022

@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Base: 41.75% // Head: 40.35% // Decreases project coverage by -1.40% ⚠️

Coverage data is based on head (0e6df47) compared to base (1828406).
Patch coverage: 0.70% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           feature    #2874      +/-   ##
===========================================
- Coverage    41.75%   40.35%   -1.41%     
===========================================
  Files          545      545              
  Lines        25848    25818      -30     
  Branches       261      262       +1     
===========================================
- Hits         10792    10418     -374     
- Misses       15016    15360     +344     
  Partials        40       40              
Impacted Files Coverage Δ
components/core/JsInterop/JSInteropConstants.cs 29.00% <0.00%> (-1.40%) ⬇️
...ore/JsInterop/modules/components/mentionsHelper.ts 0.00% <0.00%> (ø)
components/mentions/Mentions.razor 0.00% <0.00%> (ø)
components/mentions/Mentions.razor.cs 0.00% <0.00%> (ø)
components/mentions/MentionsOption.razor 0.00% <0.00%> (ø)
components/mentions/MentionsOption.razor.cs 0.00% <0.00%> (ø)
...ponents/core/Component/Overlay/type/TriggerType.cs 77.77% <50.00%> (-3.48%) ⬇️
components/list/ListItemLayout.cs 0.00% <0.00%> (-100.00%) ⬇️
components/list/ListItem.razor 0.00% <0.00%> (-95.31%) ⬇️
components/list/AntList.razor 0.00% <0.00%> (-92.31%) ⬇️
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ElderJames ElderJames merged commit 7ad1566 into ant-design-blazor:feature Nov 13, 2022
@dingyanwu dingyanwu deleted the feature branch November 13, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants