Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: no animation effect when the secondary menu is expanded and coll… #2876

Merged
merged 2 commits into from
Nov 14, 2022

Conversation

wangj90
Copy link
Contributor

@wangj90 wangj90 commented Nov 12, 2022

…apsed

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix the bug that the arrow of submenu has no animation effect when it is expanded and collapsed
🇨🇳 Chinese 修复二级菜单的箭头展开和折叠时没有动画效果的问题

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Nov 12, 2022

@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Base: 43.17% // Head: 44.60% // Increases project coverage by +1.43% 🎉

Coverage data is based on head (6b45ee2) compared to base (e4834ed).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2876      +/-   ##
==========================================
+ Coverage   43.17%   44.60%   +1.43%     
==========================================
  Files         545      545              
  Lines       25783    25779       -4     
  Branches      261      261              
==========================================
+ Hits        11133    11500     +367     
+ Misses      14610    14239     -371     
  Partials       40       40              
Impacted Files Coverage Δ
components/menu/SubMenu.razor.cs 73.46% <100.00%> (ø)
components/select/Select.razor.cs 53.18% <0.00%> (+0.26%) ⬆️
components/select/SelectBase.cs 71.19% <0.00%> (+0.27%) ⬆️
components/input/Input.cs 67.25% <0.00%> (+0.35%) ⬆️
components/date-picker/internal/DatePickerBase.cs 78.87% <0.00%> (+0.67%) ⬆️
components/core/CssSizeLength.cs 86.07% <0.00%> (+1.07%) ⬆️
components/grid/Col.razor.cs 96.00% <0.00%> (+1.33%) ⬆️
components/core/Extensions/JSRuntimeExtensions.cs 53.33% <0.00%> (+3.33%) ⬆️
components/grid/Row.razor.cs 84.44% <0.00%> (+8.88%) ⬆️
components/core/Base/AntInputComponentBase.cs 73.33% <0.00%> (+11.42%) ⬆️
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ElderJames ElderJames merged commit 0995fb0 into ant-design-blazor:master Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants