Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:(module:datepicker): incorrect week comparison causes disabled input #2889

Merged

Conversation

Alexbits
Copy link
Contributor

@Alexbits Alexbits commented Nov 20, 2022

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

This fixes an issue where an incorrect week comparison makes it impossible to select the week from a different year. The week comparison should also check the date's year, not only the week's number.

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Nov 20, 2022

@codecov
Copy link

codecov bot commented Nov 20, 2022

Codecov Report

Base: 43.60% // Head: 45.00% // Increases project coverage by +1.39% 🎉

Coverage data is based on head (461ee24) compared to base (18ff8e3).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2889      +/-   ##
==========================================
+ Coverage   43.60%   45.00%   +1.39%     
==========================================
  Files         551      551              
  Lines       25920    25917       -3     
  Branches      263      263              
==========================================
+ Hits        11302    11663     +361     
+ Misses      14578    14214     -364     
  Partials       40       40              
Impacted Files Coverage Δ
components/date-picker/RangePicker.razor.cs 65.21% <0.00%> (-0.22%) ⬇️
components/core/Component/Overlay/Overlay.razor.cs 73.83% <0.00%> (-6.98%) ⬇️
...nts/core/Component/Overlay/OverlayTrigger.razor.cs 52.87% <0.00%> (-2.62%) ⬇️
components/select/Select.razor.cs 53.24% <0.00%> (+0.26%) ⬆️
components/select/SelectBase.cs 71.19% <0.00%> (+0.27%) ⬆️
components/input/Input.cs 69.12% <0.00%> (+0.35%) ⬆️
components/date-picker/internal/DatePickerBase.cs 79.01% <0.00%> (+0.66%) ⬆️
components/core/CssSizeLength.cs 86.07% <0.00%> (+1.07%) ⬆️
components/grid/Col.razor.cs 96.00% <0.00%> (+1.33%) ⬆️
components/core/Extensions/JSRuntimeExtensions.cs 53.33% <0.00%> (+3.33%) ⬆️
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ElderJames ElderJames merged commit b83175b into ant-design-blazor:master Nov 20, 2022
@Alexbits Alexbits deleted the fix/range-picker-week-compare branch November 20, 2022 17:33
kooliokey pushed a commit to kooliokey/ant-design-blazor that referenced this pull request Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants