Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: table): Infinite loop when HidePagination and PageSize were set at the same time and datasource is empty. #2919

Merged
merged 1 commit into from
Nov 30, 2022

Conversation

ElderJames
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fixed #2904

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

…` were set at the same time and datasource is empty.
@github-actions
Copy link

github-actions bot commented Nov 30, 2022

@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Base: 45.00% // Head: 44.98% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (4320929) compared to base (f55ad09).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2919      +/-   ##
==========================================
- Coverage   45.00%   44.98%   -0.02%     
==========================================
  Files         551      551              
  Lines       25918    25918              
  Branches      263      263              
==========================================
- Hits        11664    11659       -5     
- Misses      14214    14219       +5     
  Partials       40       40              
Impacted Files Coverage Δ
components/table/Table.razor.cs 0.00% <0.00%> (ø)
components/drawer/Drawer.razor.cs 90.25% <0.00%> (-3.25%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ElderJames ElderJames merged commit e9382b8 into master Nov 30, 2022
@ElderJames ElderJames deleted the fix/table-hide-pagination branch November 30, 2022 04:14
kooliokey pushed a commit to kooliokey/ant-design-blazor that referenced this pull request Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant