-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(module: Form) Add RequiredMark to Form #2930
Merged
ElderJames
merged 5 commits into
ant-design-blazor:master
from
wss-kroche:feature/737790-required-mark
Dec 15, 2022
Merged
feat(module: Form) Add RequiredMark to Form #2930
ElderJames
merged 5 commits into
ant-design-blazor:master
from
wss-kroche:feature/737790-required-mark
Dec 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks you for contribute this @wss-kroche , I think the text for |
@ElderJames Ah good point. I will work on adding localization for that optional string text |
ElderJames
reviewed
Dec 6, 2022
7c9d0aa
to
cc89399
Compare
ElderJames
approved these changes
Dec 15, 2022
kooliokey
pushed a commit
to kooliokey/ant-design-blazor
that referenced
this pull request
Jan 15, 2023
* Add RequiredMark to Form * Add localization for form optional label * fix locales * fix test Co-authored-by: James Yeung <shunjiey@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
The react version of Ant Design has an option for "RequiredMark" which allows flagging optional, required or neither fields in a form.
Maintained backwards compatibility by defaulting this new option to "Required" which is the current functionality.
💡 Background and solution
📝 Changelog
☑️ Self Check before Merge