Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module: Form) Add RequiredMark to Form #2930

Merged

Conversation

wss-kroche
Copy link
Contributor

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

The react version of Ant Design has an option for "RequiredMark" which allows flagging optional, required or neither fields in a form.

Maintained backwards compatibility by defaulting this new option to "Required" which is the current functionality.

💡 Background and solution

image
image

📝 Changelog

Language Changelog
🇺🇸 English Add RequiredMark to Form to allow displaying indicators next to required, optional or no fields.
🇨🇳 Chinese 将 RequiredMark 添加到表单以允许在必填、可选或无字段旁边显示指示符。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Dec 5, 2022

@dnfadmin
Copy link

dnfadmin commented Dec 5, 2022

CLA assistant check
All CLA requirements met.

@wss-kroche wss-kroche changed the title Add RequiredMark to Form feat(module: Form) Add RequiredMark to Form Dec 5, 2022
@ElderJames
Copy link
Member

Thanks you for contribute this @wss-kroche , I think the text for optional is using locales.

@wss-kroche
Copy link
Contributor Author

@ElderJames Ah good point. I will work on adding localization for that optional string text

@ElderJames ElderJames enabled auto-merge (squash) December 15, 2022 13:54
@ElderJames ElderJames merged commit 67eff2b into ant-design-blazor:master Dec 15, 2022
kooliokey pushed a commit to kooliokey/ant-design-blazor that referenced this pull request Jan 15, 2023
* Add RequiredMark to Form

* Add localization for form optional label

* fix locales

* fix test

Co-authored-by: James Yeung <shunjiey@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants