feat(module: datepicker): use custom suffix icon in RangePicker compo… #2935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
|
Thank you for contribution @wss-javeney . Pleaes sign the CLA. |
Codecov ReportBase: 43.58% // Head: 43.57% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2935 +/- ##
==========================================
- Coverage 43.58% 43.57% -0.01%
==========================================
Files 551 551
Lines 25934 25934
Branches 263 263
==========================================
- Hits 11304 11302 -2
- Misses 14590 14592 +2
Partials 40 40
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Hello @ElderJames, I am still waiting for my company's review of the CLA before I am able to sign it. |
|
All right 😅. This CLA just from the dotnet foundation, as same as the official dotnet projects. |
ElderJames
approved these changes
Dec 14, 2022
kooliokey
pushed a commit
to kooliokey/ant-design-blazor
that referenced
this pull request
Jan 15, 2023
…blazor#2935) * feat(module: datepicker): use custom suffix icon in RangePicker component * fix whitespace in test file * Update suffix-icon.md Co-authored-by: James Yeung <shunjiey@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
The RangePicker component accepts a RenderFragment for SuffixIcon but was not using it. This PR has the base date picker component for End Date accept the RenderFragment.
💡 Background and solution
📝 Changelog
☑️ Self Check before Merge