Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:tree-select): Add TitleTemplate parameter #2940

Merged

Conversation

rhodon-jargon
Copy link
Contributor

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#2939

💡 Background and solution

The TreeSelect component didn't allow a TitleTemplate attribute to be specified. This adds that as a parameter.

📝 Changelog

Language Changelog
🇺🇸 English It is now possible to override the TitleTemplate in a TreeSelect component
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@dnfadmin
Copy link

dnfadmin commented Dec 9, 2022

CLA assistant check
All CLA requirements met.

@github-actions
Copy link

github-actions bot commented Dec 9, 2022

@ElderJames
Copy link
Member

Thank you for contribution @rhodon-jargon , please sign the CLA.

@rhodon-jargon
Copy link
Contributor Author

Thank you for contribution @rhodon-jargon , please sign the CLA.

Sorry, I thought I already did, but the CLA website is a bit buggy. Now I did!

@codecov
Copy link

codecov bot commented Dec 11, 2022

Codecov Report

Base: 44.98% // Head: 43.51% // Decreases project coverage by -1.46% ⚠️

Coverage data is based on head (196c0bf) compared to base (ca8ad80).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2940      +/-   ##
==========================================
- Coverage   44.98%   43.51%   -1.47%     
==========================================
  Files         551      551              
  Lines       25919    25924       +5     
  Branches      263      263              
==========================================
- Hits        11659    11281     -378     
- Misses      14220    14603     +383     
  Partials       40       40              
Impacted Files Coverage Δ
components/tree-select/TreeSelect.razor 0.00% <ø> (ø)
components/tree-select/TreeSelect.razor.cs 0.00% <0.00%> (ø)
components/list/ListItemLayout.cs 0.00% <0.00%> (-100.00%) ⬇️
components/list/ListItem.razor 0.00% <0.00%> (-95.31%) ⬇️
components/list/AntList.razor 0.00% <0.00%> (-92.31%) ⬇️
...omponents/form/Validate/Rule/FormRulesValidator.cs 0.00% <0.00%> (-76.93%) ⬇️
components/list/AntList.razor.cs 0.00% <0.00%> (-76.12%) ⬇️
components/list/ListItem.razor.cs 0.00% <0.00%> (-73.08%) ⬇️
components/form/Form.razor.cs 36.02% <0.00%> (-32.30%) ⬇️
components/form/FormItem.razor.cs 43.31% <0.00%> (-29.94%) ⬇️
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ElderJames ElderJames merged commit bd2f2a2 into ant-design-blazor:master Dec 11, 2022
kooliokey pushed a commit to kooliokey/ant-design-blazor that referenced this pull request Jan 15, 2023
@rhodon-jargon rhodon-jargon deleted the tree-select-title-template branch April 11, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants