Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: table): can't restore the query state of filters which value is enum type #2941

Merged
merged 1 commit into from
Dec 11, 2022

Conversation

ElderJames
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fixed #2938

💡 Background and solution

Enum types can not use == when they are boxed.

📝 Changelog

Language Changelog
🇺🇸 English Fxied Table can't restore the query state of filters which value is enum type
🇨🇳 Chinese 修复 Table 不能恢复枚举类型的 Filter 的查询状态

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Dec 11, 2022

@codecov
Copy link

codecov bot commented Dec 11, 2022

Codecov Report

Base: 44.98% // Head: 45.00% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (89cd268) compared to base (ca8ad80).
Patch coverage: 33.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2941      +/-   ##
==========================================
+ Coverage   44.98%   45.00%   +0.01%     
==========================================
  Files         551      551              
  Lines       25919    25920       +1     
  Branches      263      263              
==========================================
+ Hits        11659    11664       +5     
+ Misses      14220    14216       -4     
  Partials       40       40              
Impacted Files Coverage Δ
components/table/Column.razor.cs 0.00% <0.00%> (ø)
components/tree-select/TreeSelect.razor 0.00% <ø> (ø)
components/tree-select/TreeSelect.razor.cs 0.00% <0.00%> (ø)
components/core/Helpers/ClassMapper.cs 95.00% <100.00%> (ø)
components/drawer/Drawer.razor.cs 93.50% <0.00%> (+3.24%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ElderJames ElderJames merged commit 59db656 into master Dec 11, 2022
@ElderJames ElderJames deleted the fix/table-restore-state-filter branch December 11, 2022 15:06
kooliokey pushed a commit to kooliokey/ant-design-blazor that referenced this pull request Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table -> Restore Query State : issue when saving/loading JSON
1 participant