Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: statistic): countdown format incorrectly when publish with trimming #2943

Merged
merged 1 commit into from
Dec 14, 2022

Conversation

ElderJames
Copy link
Member

@ElderJames ElderJames commented Dec 13, 2022

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fixed #1474
fixed #2917

💡 Background and solution

https://devblogs.microsoft.com/dotnet/customizing-trimming-in-net-core-5/?WT.mc_id=DT-MVP-5003987#annotating-reflection

📝 Changelog

Language Changelog
🇺🇸 English Fixed Statistic CountDown format incorrectly when publish with trimming
🇨🇳 Chinese 修复 Statistic 的 CountDown 再裁剪发布时格式化无效的问题

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Dec 13, 2022

@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Base: 43.51% // Head: 43.51% // No change to project coverage 👍

Coverage data is based on head (391b14e) compared to base (59db656).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2943   +/-   ##
=======================================
  Coverage   43.51%   43.51%           
=======================================
  Files         551      551           
  Lines       25924    25924           
  Branches      263      263           
=======================================
  Hits        11281    11281           
  Misses      14603    14603           
  Partials       40       40           
Impacted Files Coverage Δ
components/core/Helpers/Formatter.cs 77.77% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ElderJames ElderJames merged commit d279796 into master Dec 14, 2022
@ElderJames ElderJames deleted the fix/coundown-format-trim branch December 14, 2022 08:20
kooliokey pushed a commit to kooliokey/ant-design-blazor that referenced this pull request Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CountDown - format has no effect when publish CountDown: Format has no effect
1 participant