Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 2921 Fix IQueryable or IEnumerable using AsNoTracking will cause select data duplication bug #2944

Merged
merged 5 commits into from
Dec 14, 2022

Conversation

dashiell-zhang
Copy link
Member

fix #2921
Fix IQueryable or IEnumerable using AsNoTracking will cause select data duplication bug

@github-actions
Copy link

github-actions bot commented Dec 14, 2022

@dashiell-zhang dashiell-zhang changed the title fix 2921 fix 2921 Fix IQueryable or IEnumerable using AsNoTracking will cause select data duplication bug Dec 14, 2022
@codecov
Copy link

codecov bot commented Dec 14, 2022

Codecov Report

Base: 44.98% // Head: 43.51% // Decreases project coverage by -1.46% ⚠️

Coverage data is based on head (1f7bbf3) compared to base (d279796).
Patch coverage: 0.00% of modified lines in pull request are covered.

❗ Current head 1f7bbf3 differs from pull request most recent head 0d2595c. Consider uploading reports for the commit 0d2595c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2944      +/-   ##
==========================================
- Coverage   44.98%   43.51%   -1.47%     
==========================================
  Files         551      551              
  Lines       25920    25926       +6     
  Branches      263      263              
==========================================
- Hits        11659    11281     -378     
- Misses      14221    14605     +384     
  Partials       40       40              
Impacted Files Coverage Δ
components/table/Table.razor.Selection.cs 0.00% <0.00%> (ø)
components/table/Table.razor.cs 0.00% <0.00%> (ø)
components/list/ListItemLayout.cs 0.00% <0.00%> (-100.00%) ⬇️
components/list/ListItem.razor 0.00% <0.00%> (-95.31%) ⬇️
components/list/AntList.razor 0.00% <0.00%> (-92.31%) ⬇️
...omponents/form/Validate/Rule/FormRulesValidator.cs 0.00% <0.00%> (-76.93%) ⬇️
components/list/AntList.razor.cs 0.00% <0.00%> (-76.12%) ⬇️
components/list/ListItem.razor.cs 0.00% <0.00%> (-73.08%) ⬇️
components/form/Form.razor.cs 36.02% <0.00%> (-32.30%) ⬇️
components/form/FormItem.razor.cs 43.31% <0.00%> (-29.94%) ⬇️
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ElderJames ElderJames merged commit b29ad76 into ant-design-blazor:master Dec 14, 2022
@dashiell-zhang dashiell-zhang deleted the fix2921 branch January 9, 2023 12:21
kooliokey pushed a commit to kooliokey/ant-design-blazor that referenced this pull request Jan 15, 2023
…ill cause select data duplication bug (ant-design-blazor#2944)

* fix 2921 Fix IQueryable or IEnumerable using AsNoTracking will cause select data duplication bug

* Optimize ToList action after pagination
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When the datasource of table comes from dataset and AsNoTracking, all selection will be doubled
2 participants