refactor(notification): update NotificationService to use interface #2948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov ReportBase: 43.57% // Head: 45.03% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2948 +/- ##
==========================================
+ Coverage 43.57% 45.03% +1.46%
==========================================
Files 551 551
Lines 25936 25933 -3
Branches 263 263
==========================================
+ Hits 11302 11680 +378
+ Misses 14594 14213 -381
Partials 40 40
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ElderJames
approved these changes
Dec 16, 2022
|
Please show how to add a test with Notification, just add it in the test project. |
…/github.com/wss-javeney/ant-design-blazor into implement-notification-service-as-interface
kooliokey
pushed a commit
to kooliokey/ant-design-blazor
that referenced
this pull request
Jan 15, 2023
…erface (ant-design-blazor#2948) * refactor(notification): update NotificationService to use interface * Add example unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
It is not possible to test that an application triggered an AntDesign.Notification currently due to it being a concrete class. This refactors it into a class that implements an interface. Users can use dependency injection now and unit test that the code triggered notifications to show.
📝 Changelog
☑️ Self Check before Merge